public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/20199] consider integral type synonyms as being equal
Date: Fri, 01 Jan 2016 00:00:00 -0000	[thread overview]
Message-ID: <bug-20199-9487-woA5qhqTOF@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-20199-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=20199

--- Comment #7 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #6)
> but remember to also take care of:
> 
> type name changed from '_Bool' to 'unsigned char'

This is a different problem.

_Bool and unsigned char are different built-in types.  _Bool appeared in C11
(http://en.cppreference.com/w/c/types/boolean).  So I think they ought to
compare different.

Whereas 'unsigned short' and "short unsigned int" are exactly the same type,
and so should compare equal, even if the strings representing their names are
different.

In my opinion the '_Bool' to 'unsigned char' change is potentially a real
problem, at least from an API point of view.  So I think it's useful that
abidiff tells users about it.  If, in a particular context of a particular
project users (after carefully reviewing all the reported instances of changes
from _Bool to unsigned char) decide that they want the tool to suppress those
change reports, then I think they should use a suppression specification
instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2016-07-14 15:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01  0:00 [Bug default/20199] New: disregard harmless type synonyms woodard at redhat dot com
2016-01-01  0:00 ` [Bug default/20199] " woodard at redhat dot com
2016-01-01  0:00 ` woodard at redhat dot com
2016-01-01  0:00 ` [Bug default/20199] consider integral type synonyms as being equal dodji at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com [this message]
2016-01-01  0:00 ` [Bug default/20199] disregard harmless type synonyms woodard at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com
2016-01-01  0:00 ` woodard at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-20199-9487-woA5qhqTOF@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).