From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85242 invoked by alias); 14 Jul 2016 15:11:39 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 85086 invoked by uid 48); 14 Jul 2016 15:11:26 -0000 From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/20199] consider integral type synonyms as being equal Date: Fri, 01 Jan 2016 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2016-q3/txt/msg00046.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D20199 --- Comment #7 from dodji at redhat dot com --- (In reply to Ben Woodard from comment #6) > but remember to also take care of: >=20 > type name changed from '_Bool' to 'unsigned char' This is a different problem. _Bool and unsigned char are different built-in types. _Bool appeared in C11 (http://en.cppreference.com/w/c/types/boolean). So I think they ought to compare different. Whereas 'unsigned short' and "short unsigned int" are exactly the same type, and so should compare equal, even if the strings representing their names a= re different. In my opinion the '_Bool' to 'unsigned char' change is potentially a real problem, at least from an API point of view. So I think it's useful that abidiff tells users about it. If, in a particular context of a particular project users (after carefully reviewing all the reported instances of chan= ges from _Bool to unsigned char) decide that they want the tool to suppress tho= se change reports, then I think they should use a suppression specification instead. --=20 You are receiving this mail because: You are on the CC list for the bug.