public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/20201] New: missing structure member
@ 2016-01-01  0:00 woodard at redhat dot com
  2016-01-01  0:00 ` [Bug default/20201] " dodji at redhat dot com
  0 siblings, 1 reply; 2+ messages in thread
From: woodard at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20201

            Bug ID: 20201
           Summary: missing structure member
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

The error that I'm looking at is:

  [C]'function size_t _elf32_xltsize(const Elf_Data*, unsigned int, unsigned
int, int)' at 32.xlate\
tof.c:336:1 has some indirect sub-type changes:

    parameter 1 of type 'const Elf_Data*' has sub-type changes:
      in pointed to type 'const Elf_Data':
        in unqualified underlying type 'typedef Elf_Data' at libelf.h:167:1:
          underlying type 'struct __anonymous_struct__' at libelf.h:160:1
changed:
            1 data member deletion:
              'void* __anonymous_struct__::d_buf', at offset 0 (in bits) at
libelf.h:161:1

So I go over and look at the GCC DWARF and I see:

 <1><7ec>: Abbrev Number: 4 (DW_TAG_typedef)
    <7ed>   DW_AT_name        : (indirect string, offset: 0x7b5): Elf_Data
    <7f1>   DW_AT_decl_file   : 11
    <7f2>   DW_AT_decl_line   : 167
    <7f3>   DW_AT_type        : <0x79b>

 <1><79b>: Abbrev Number: 22 (DW_TAG_structure_type)
    <79c>   DW_AT_byte_size   : 48
    <79d>   DW_AT_decl_file   : 11
    <79e>   DW_AT_decl_line   : 160
    <79f>   DW_AT_sibling     : <0x7ec>
 <2><7a3>: Abbrev Number: 13 (DW_TAG_member)
    <7a4>   DW_AT_name        : (indirect string, offset: 0x834): d_buf
    <7a8>   DW_AT_decl_file   : 11
    <7a9>   DW_AT_decl_line   : 161
    <7aa>   DW_AT_type        : <0x98>
    <7ae>   DW_AT_data_member_location: 0

Then I go over and compare it to what I see from Intel's 16.0.2 compiler:

 <1><56d>: Abbrev Number: 10 (DW_TAG_typedef)
    <56e>   DW_AT_decl_line   : 167
    <56f>   DW_AT_decl_file   : 2
    <570>   DW_AT_name        : (indirect string, offset: 0x2c6): Elf_Data
    <574>   DW_AT_type        : <0x578>
 <1><578>: Abbrev Number: 15 (DW_TAG_structure_type)
    <579>   DW_AT_decl_line   : 160
    <57a>   DW_AT_decl_file   : 2
    <57b>   DW_AT_byte_size   : 48
 <2><57c>: Abbrev Number: 8 (DW_TAG_member)
    <57d>   DW_AT_decl_line   : 161
    <57e>   DW_AT_decl_file   : 2
    <57f>   DW_AT_data_member_location: 2 byte block: 23 0     
(DW_OP_plus_uconst: 0)
    <582>   DW_AT_name        : (indirect string, offset: 0x2d4): d_buf
    <586>   DW_AT_type        : <0x5d1>

And it looks to me like d_buf is there and in the right place. It is just that
libabigail doesn't consider:
    <7ae>   DW_AT_data_member_location: 0
and 
    <57f>   DW_AT_data_member_location: 2 byte block: 23 0     
(DW_OP_plus_uconst: 0)
to be the same thing in this one case. 

The odd thing to me is that it only seems to point out a problem with the first
member of this structure.

The object files to reproduce this issue are attached to PR#20194

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug default/20201] missing structure member
  2016-01-01  0:00 [Bug default/20201] New: missing structure member woodard at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  0 siblings, 0 replies; 2+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20201

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
I think this issue is an artifact of Bug #20194 - Fail to recognize void type
represented by DW_TAG_base_type and should be fixed by the fix to that bug.

Thank you for reporting this problem!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-08  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-01  0:00 [Bug default/20201] New: missing structure member woodard at redhat dot com
2016-01-01  0:00 ` [Bug default/20201] " dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).