public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/20534] Display name instead of address for added binary files
  2016-01-01  0:00 [Bug default/20534] New: Display name instead of address for added binary files sinny at redhat dot com
                   ` (2 preceding siblings ...)
  2016-01-01  0:00 ` sinny at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  2016-01-01  0:00 ` dodji at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20534

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from dodji at redhat dot com ---
(In reply to dodji from comment #3)

> So I have added a proper ChangeLog entry for it and applied it to the master
> branch of our Git repository.

The patch can be viewed at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=3227d2156af2b8a86b8b4bf197c4d1a0fdf3d2fe

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/20534] Display name instead of address for added binary files
  2016-01-01  0:00 [Bug default/20534] New: Display name instead of address for added binary files sinny at redhat dot com
@ 2016-01-01  0:00 ` sinny at redhat dot com
  2016-01-01  0:00 ` sinny at redhat dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sinny at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20534

--- Comment #5 from Sinny Kumari <sinny at redhat dot com> ---
(In reply to dodji from comment #3)
> Comment on attachment 9482 [details]
> Display name instead of address of added file
> 
> Patch looks obvious and good!
> 
> So I have added a proper ChangeLog entry for it and applied it to the master
> branch of our Git repository.

Thanks Dodji!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/20534] Display name instead of address for added binary files
  2016-01-01  0:00 [Bug default/20534] New: Display name instead of address for added binary files sinny at redhat dot com
  2016-01-01  0:00 ` [Bug default/20534] " sinny at redhat dot com
@ 2016-01-01  0:00 ` sinny at redhat dot com
  2016-01-01  0:00 ` sinny at redhat dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sinny at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20534

--- Comment #2 from Sinny Kumari <sinny at redhat dot com> ---
(In reply to Sinny Kumari from comment #0)
> Problem Description
> -------------------
> 
> During abipkgdiff run, if result has any added binary file to show then it
> should show name but currently it prints address.
> 
> For example:
> Pacakge1 -
> https://kojipkgs.fedoraproject.org//packages/binutils/2.26/23.fc25/armv7hl/
> binutils-2.26-23.fc25.armv7hl.rpm
> Package 2-
> https://kojipkgs.fedoraproject.org//packages/binutils/2.26.1/1.fc25/armv7hl/
> binutils-2.26.1-1.fc25.armv7hl.rpm
> 
> $ abipkgdiff binutils-2.26-23.fc25.armv7hl.rpm
> binutils-2.26.1-1.fc25.armv7hl.rpm 
> 
> Removed binaries:
>   libbfd-2.26.20160125.so, SONAME: libbfd-2.26.20160125.so
>   libopcodes-2.26.20160125.so, SONAME: libopcodes-2.26.20160125.so
> Added binaries:
>   libbfd-2.26.1-1.fc25.so, SONAME: libbfd-2.26.1-1.fc25.so
>   libopcodes-2.26.1-1.fc25.so, SONAME: libopcodes-2.26.1-1.fc25.so

Sorry about copy pasting mistake, actual output before fix was like:

Removed binaries:
  libbfd-2.26.20160125.so, SONAME: libbfd-2.26.20160125.so
  libopcodes-2.26.20160125.so, SONAME: libopcodes-2.26.20160125.so
Added binaries:
  0x7f3bb0002210, SONAME: libbfd-2.26.1-1.fc25.so
  0x7f3bb0001ff0, SONAME: libopcodes-2.26.1-1.fc25.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/20534] Display name instead of address for added binary files
  2016-01-01  0:00 [Bug default/20534] New: Display name instead of address for added binary files sinny at redhat dot com
  2016-01-01  0:00 ` [Bug default/20534] " sinny at redhat dot com
  2016-01-01  0:00 ` sinny at redhat dot com
@ 2016-01-01  0:00 ` sinny at redhat dot com
  2016-01-01  0:00 ` dodji at redhat dot com
  2016-01-01  0:00 ` dodji at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: sinny at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20534

--- Comment #1 from Sinny Kumari <sinny at redhat dot com> ---
Created attachment 9482
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9482&action=edit
Display name instead of address of added file

This patch fixes the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/20534] New: Display name instead of address for added binary files
@ 2016-01-01  0:00 sinny at redhat dot com
  2016-01-01  0:00 ` [Bug default/20534] " sinny at redhat dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: sinny at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20534

            Bug ID: 20534
           Summary: Display name instead of address for added binary files
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: sinny at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Problem Description
-------------------

During abipkgdiff run, if result has any added binary file to show then it
should show name but currently it prints address.

For example:
Pacakge1 -
https://kojipkgs.fedoraproject.org//packages/binutils/2.26/23.fc25/armv7hl/binutils-2.26-23.fc25.armv7hl.rpm
Package 2-
https://kojipkgs.fedoraproject.org//packages/binutils/2.26.1/1.fc25/armv7hl/binutils-2.26.1-1.fc25.armv7hl.rpm

$ abipkgdiff binutils-2.26-23.fc25.armv7hl.rpm
binutils-2.26.1-1.fc25.armv7hl.rpm 

Removed binaries:
  libbfd-2.26.20160125.so, SONAME: libbfd-2.26.20160125.so
  libopcodes-2.26.20160125.so, SONAME: libopcodes-2.26.20160125.so
Added binaries:
  libbfd-2.26.1-1.fc25.so, SONAME: libbfd-2.26.1-1.fc25.so
  libopcodes-2.26.1-1.fc25.so, SONAME: libopcodes-2.26.1-1.fc25.so

Expected Result:
---------------
Show name of added binary files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/20534] Display name instead of address for added binary files
  2016-01-01  0:00 [Bug default/20534] New: Display name instead of address for added binary files sinny at redhat dot com
                   ` (3 preceding siblings ...)
  2016-01-01  0:00 ` dodji at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20534

--- Comment #3 from dodji at redhat dot com ---
Comment on attachment 9482
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9482
Display name instead of address of added file

Patch looks obvious and good!

So I have added a proper ChangeLog entry for it and applied it to the master
branch of our Git repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-08-31 18:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-01  0:00 [Bug default/20534] New: Display name instead of address for added binary files sinny at redhat dot com
2016-01-01  0:00 ` [Bug default/20534] " sinny at redhat dot com
2016-01-01  0:00 ` sinny at redhat dot com
2016-01-01  0:00 ` sinny at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).