public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/20927] New: Segfault occur when invoke abidiff in rpmdiff-workerd demon
@ 2016-01-01  0:00 yashi at redhat dot com
  2016-01-01  0:00 ` [Bug default/20927] Segfault when abidiff is invoked with $HOME empty dodji at redhat dot com
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: yashi at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20927

            Bug ID: 20927
           Summary: Segfault occur when invoke abidiff in rpmdiff-workerd
                    demon
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: critical
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: yashi at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Test with libabigail-1.0-0.8.rc6.2.el7

You will get empty $HOME when invoke abidiff in a demon service, it is blocking
rpmdiff 4.0.1 release.

We have to start rpmdiff-workerd service this way right now.
/etc/init.d/rpmdiff-workerd start on rhel7, that is not a good idea.

Fix it and make a new libabigail release will be very appreciated.

please add a check when try to do assignment: 
if (s) default_user_suppr_path  = s;

src/abg-tools-utils.cc
 910 /// Get the path to the default user suppression file.$
 911 ///$
 912 /// @return a copy of the default user suppression file.$
 913 string$
 914 get_default_user_suppression_file_path()$
 915 {$
 916   string default_user_suppr_path;$
 917   const char *s = getenv("LIBABIGAIL_DEFAULT_USER_SUPPRESSION_FILE");$
 918 $
 919   if (s == NULL)$
 920     {$
 921       s = getenv("HOME");$
 922       default_user_suppr_path  = s;$
 923       if (default_user_suppr_path.empty())$
 924 >---default_user_suppr_path = "~";$
 925       default_user_suppr_path += "/.abignore";$

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20927] Segfaultwhen invoke abidiff is invoked with $HOME not set
  2016-01-01  0:00 [Bug default/20927] New: Segfault occur when invoke abidiff in rpmdiff-workerd demon yashi at redhat dot com
  2016-01-01  0:00 ` [Bug default/20927] Segfault when abidiff is invoked with $HOME empty dodji at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  2016-01-01  0:00 ` [Bug default/20927] Segfault when " dodji at redhat dot com
  2016-01-01  0:00 ` dodji at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20927

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Segfault occur when invoke  |Segfaultwhen invoke abidiff
                   |abidiff in rpmdiff-workerd  |is invoked with $HOME not
                   |demon                       |set

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20927] Segfault when invoke abidiff is invoked with $HOME not set
  2016-01-01  0:00 [Bug default/20927] New: Segfault occur when invoke abidiff in rpmdiff-workerd demon yashi at redhat dot com
  2016-01-01  0:00 ` [Bug default/20927] Segfault when abidiff is invoked with $HOME empty dodji at redhat dot com
  2016-01-01  0:00 ` [Bug default/20927] Segfaultwhen invoke abidiff is invoked with $HOME not set dodji at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  2016-01-01  0:00 ` dodji at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20927

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Segfaultwhen invoke abidiff |Segfault when invoke
                   |is invoked with $HOME not   |abidiff is invoked with
                   |set                         |$HOME not set

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20927] Segfault when abidiff is invoked with $HOME empty
  2016-01-01  0:00 [Bug default/20927] New: Segfault occur when invoke abidiff in rpmdiff-workerd demon yashi at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  2016-01-01  0:00 ` [Bug default/20927] Segfaultwhen invoke abidiff is invoked with $HOME not set dodji at redhat dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20927

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Segfault when invoke        |Segfault when abidiff is
                   |abidiff is invoked with     |invoked with $HOME empty
                   |$HOME not set               |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20927] Segfault when invoke abidiff is invoked with $HOME not set
  2016-01-01  0:00 [Bug default/20927] New: Segfault occur when invoke abidiff in rpmdiff-workerd demon yashi at redhat dot com
                   ` (2 preceding siblings ...)
  2016-01-01  0:00 ` [Bug default/20927] Segfault when " dodji at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20927

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
This issue was fixed in the master branch of the git repository at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=985397a47a098dbc624d01dd79e67d2b9ebd3d4c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-12-05 12:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-01  0:00 [Bug default/20927] New: Segfault occur when invoke abidiff in rpmdiff-workerd demon yashi at redhat dot com
2016-01-01  0:00 ` [Bug default/20927] Segfault when abidiff is invoked with $HOME empty dodji at redhat dot com
2016-01-01  0:00 ` [Bug default/20927] Segfaultwhen invoke abidiff is invoked with $HOME not set dodji at redhat dot com
2016-01-01  0:00 ` [Bug default/20927] Segfault when " dodji at redhat dot com
2016-01-01  0:00 ` dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).