public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/20970] New: abidw should have an --annotate option
@ 2016-01-01  0:00 ondrej.oprala at gmail dot com
  2016-01-01  0:00 ` [Bug default/20970] " ondrej.oprala at gmail dot com
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: ondrej.oprala at gmail dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20970

            Bug ID: 20970
           Summary: abidw should have an --annotate option
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: ondrej.oprala at gmail dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This bug is based on Bug 18838 (comment 7):
========================================
Another thing I think should be added to the xml output (I am calling the xml
format abixml now) is annotations to make the output easier to read and
understand.

for instance, if in abixml you have this:

   <type-decl name='char' size-in-bits='8' id='type-id-7'/>
    (...)
   <qualified-type-def type-id='type-id-7' const='yes' id='type-id-8'/>
    (...)
   <pointer-type-def type-id='type-id-8' id='type-id-9'/>

The second and third lines becomes easier to read when accompanied by a comment
like:

   <type-decl name='char' size-in-bits='8' id='type-id-7'/>
    (...)
   <!-- const char -->
   <qualified-type-def type-id='type-id-7' const='yes' id='type-id-8'/>
    (...)
   <!-- const char* -->
   <pointer-type-def type-id="type-id-8' id='type-id-8'/>

This eases reviews of changes to abixml files.

========================================

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20970] abidw should have an --annotate option
  2016-01-01  0:00 [Bug default/20970] New: abidw should have an --annotate option ondrej.oprala at gmail dot com
@ 2016-01-01  0:00 ` ondrej.oprala at gmail dot com
  2016-01-01  0:00 ` ondrej.oprala at gmail dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ondrej.oprala at gmail dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20970

Ondrej Oprala <ondrej.oprala at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20970] abidw should have an --annotate option
  2016-01-01  0:00 [Bug default/20970] New: abidw should have an --annotate option ondrej.oprala at gmail dot com
  2016-01-01  0:00 ` [Bug default/20970] " ondrej.oprala at gmail dot com
@ 2016-01-01  0:00 ` ondrej.oprala at gmail dot com
  2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: ondrej.oprala at gmail dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20970

Ondrej Oprala <ondrej.oprala at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dodji at redhat dot com            |ondrej.oprala at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20970] abidw should have an --annotate option
  2016-01-01  0:00 [Bug default/20970] New: abidw should have an --annotate option ondrej.oprala at gmail dot com
  2016-01-01  0:00 ` [Bug default/20970] " ondrej.oprala at gmail dot com
  2016-01-01  0:00 ` ondrej.oprala at gmail dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20970

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
This enhancement was committed to the master branch of the git repository at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=aba99e510647e921822354d502e345f9d1735cc8.

It should be available in the coming 1.0.rc7 release of libabigail.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/20970] abidw should have an --annotate option
  2016-01-01  0:00 [Bug default/20970] New: abidw should have an --annotate option ondrej.oprala at gmail dot com
                   ` (2 preceding siblings ...)
  2017-01-01  0:00 ` dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=20970

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dodji at redhat dot com
             Blocks|                            |19843

--- Comment #1 from dodji at redhat dot com ---
I think this enhancement would be the last task necessary before we can start
thinking about closing #19843.


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=19843
[Bug 19843] make abidw usable in the glibc build process
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-01-24 14:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-01  0:00 [Bug default/20970] New: abidw should have an --annotate option ondrej.oprala at gmail dot com
2016-01-01  0:00 ` [Bug default/20970] " ondrej.oprala at gmail dot com
2016-01-01  0:00 ` ondrej.oprala at gmail dot com
2017-01-01  0:00 ` dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).