From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/21058] abipkgdiff dropping types not defined in devel packages by default leads to wrong reports
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <bug-21058-9487-X6vAV5tZaH@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-21058-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=21058
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from dodji at redhat dot com ---
This issue should be fixed in the master branch of the git repository by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=8ae81a8e1620eea4c1a4f48c0ff53ae1184048c3.
The output that is now emitted when invoking abipkgdiff is:
dodji@adjoa:spice$ time abipkgdiff --d1
./spice-debuginfo-0.12.4-19.el7.x86_64.rpm --d2
./spice-debuginfo-0.12.8-1.el7.x86_64.rpm --devel1
./spice-server-devel-0.12.4-19.el7.x86_64.rpm --devel2
./spice-server-devel-0.12.8-1.el7.x86_64.rpm
./spice-server-0.12.4-19.el7.x86_64.rpm ./spice-server-0.12.8-1.el7.x86_64.rpm
================ changes of 'libspice-server.so.1.8.0'===============
Functions changes summary: 1 Removed, 1 Changed (63 filtered out), 8 Added
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
1 Removed function:
'function int spice_server_migrate_client_state(SpiceServer*)'
{spice_server_migrate_client_state@@SPICE_SERVER_0.6.0}
8 Added functions:
'function void spice_replay_free(SpiceReplay*)'
{spice_replay_free@@SPICE_SERVER_0.12.6}
'function void spice_replay_free_cmd(SpiceReplay*, QXLCommandExt*)'
{spice_replay_free_cmd@@SPICE_SERVER_0.12.6}
'function SpiceReplay* spice_replay_new(FILE*, int)'
{spice_replay_new@@SPICE_SERVER_0.12.6}
'function QXLCommandExt* spice_replay_next_cmd(SpiceReplay*, QXLWorker*)'
{spice_replay_next_cmd@@SPICE_SERVER_0.12.6}
'function uint32_t
spice_server_get_best_playback_rate(SpicePlaybackInstance*)'
{spice_server_get_best_playback_rate@@SPICE_SERVER_0.12.5}
'function uint32_t spice_server_get_best_record_rate(SpiceRecordInstance*)'
{spice_server_get_best_record_rate@@SPICE_SERVER_0.12.5}
'function void spice_server_set_playback_rate(SpicePlaybackInstance*,
uint32_t)' {spice_server_set_playback_rate@@SPICE_SERVER_0.12.5}
'function void spice_server_set_record_rate(SpiceRecordInstance*,
uint32_t)' {spice_server_set_record_rate@@SPICE_SERVER_0.12.5}
1 function with some indirect sub-type change:
[C]'function spice_image_compression_t
spice_server_get_image_compression(SpiceServer*)' at reds.c:3618:1 has some
indirect sub-type changes:
return type changed:
underlying type 'enum __anonymous_enum__' changed:
type size hasn't changed
7 enumerator deletions:
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_INVALID' value '0'
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_OFF' value '1'
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_AUTO_GLZ' value '2'
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_AUTO_LZ' value '3'
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_QUIC' value '4'
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_GLZ' value '5'
'__anonymous_enum__::SPICE_IMAGE_COMPRESS_LZ' value '6'
9 enumerator insertions:
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_INVALID' value '0'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_OFF' value '1'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_AUTO_GLZ' value '2'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_AUTO_LZ' value '3'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_QUIC' value '4'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_GLZ' value '5'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_LZ' value '6'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_LZ4' value '7'
'SpiceImageCompression::SPICE_IMAGE_COMPRESSION_ENUM_END' value '8'
================ end of changes of 'libspice-server.so.1.8.0'===============
real 0m1.384s
user 0m2.593s
sys 0m0.333s
dodji@adjoa:spice$
Thank you for filing this issue!
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2017-01-18 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 [Bug default/21058] New: Inaccurate abipkgdiff report cfergeau at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com [this message]
2017-01-01 0:00 ` [Bug default/21058] " dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21058] abipkgdiff dropping types not defined in devel packages by default leads to wrong reports dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-21058-9487-X6vAV5tZaH@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).