[Bug default/21058] abipkgdiff dropping types not defined in devel packages by default leads to wrong reports

["dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=21058

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inaccurate abipkgdiff       |abipkgdiff dropping types
                   |report                      |not defined in devel
                   |                            |packages by default leads
                   |                            |to wrong reports

--- Comment #1 from dodji at redhat dot com ---
I can confirm the issue.

Thank you for taking time to file this report.

The reason why the SpiceServer* type is not shown is because it has been
dropped from the internal model of libabigail.  This is triggered by the
--devel1/--devel2 option which tells the library to drop any type that is *NOT*
defined in the header files that are in the -devel packages provided.

Note that in spice.h, SpiceServer is defined as
"typedef·struct·RedsState·SpiceServer;"  And struct RedsState itself is defined
nowhere (as far as I can tell) in any of the header files that are in the devel
package.  So struct RedsState is dropped from the internal model of libabigail
when it analyzes the libspice-server.so library.

Similarly, the reason why the SpiceImageCompression type is not shown (in the
second version of libspice-server.so) is that that enum is not defined in any
of the -devel package given.  As you said it's defined in a header file that
provided by a different package altogether.  As a result of the
--devel1/--devel2 options, that type is also dropped from the internal model.

We drop types not defined in the headers (provided by the devel package) of a
given library, not only to avoid showing changes in types that are not part of
the official interface of the package, but also to help decrease libabigail's
memory consumption.

This present case seems to argue against dropping types not defined in devel
packages, at lease by default.

-- 
You are receiving this mail because:
You are on the CC list for the bug.