From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19776 invoked by alias); 18 Jan 2017 08:36:30 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 19621 invoked by uid 48); 18 Jan 2017 08:36:15 -0000 From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/21058] abipkgdiff dropping types not defined in devel packages by default leads to wrong reports Date: Sun, 01 Jan 2017 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q1/txt/msg00013.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D21058 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inaccurate abipkgdiff |abipkgdiff dropping types |report |not defined in devel | |packages by default leads | |to wrong reports --- Comment #1 from dodji at redhat dot com --- I can confirm the issue. Thank you for taking time to file this report. The reason why the SpiceServer* type is not shown is because it has been dropped from the internal model of libabigail. This is triggered by the --devel1/--devel2 option which tells the library to drop any type that is *= NOT* defined in the header files that are in the -devel packages provided. Note that in spice.h, SpiceServer is defined as "typedef=C2=B7struct=C2=B7RedsState=C2=B7SpiceServer;" And struct RedsStat= e itself is defined nowhere (as far as I can tell) in any of the header files that are in the d= evel package. So struct RedsState is dropped from the internal model of libabig= ail when it analyzes the libspice-server.so library. Similarly, the reason why the SpiceImageCompression type is not shown (in t= he second version of libspice-server.so) is that that enum is not defined in a= ny of the -devel package given. As you said it's defined in a header file that provided by a different package altogether. As a result of the --devel1/--devel2 options, that type is also dropped from the internal mode= l. We drop types not defined in the headers (provided by the devel package) of= a given library, not only to avoid showing changes in types that are not part= of the official interface of the package, but also to help decrease libabigail= 's memory consumption. This present case seems to argue against dropping types not defined in devel packages, at lease by default. --=20 You are receiving this mail because: You are on the CC list for the bug.