From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93975 invoked by alias); 17 Jan 2017 11:55:56 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 93068 invoked by uid 48); 17 Jan 2017 11:55:44 -0000 From: "cfergeau at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/21058] New: Inaccurate abipkgdiff report Date: Sun, 01 Jan 2017 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cfergeau at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q1/txt/msg00011.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D21058 Bug ID: 21058 Summary: Inaccurate abipkgdiff report Product: libabigail Version: unspecified Status: NEW Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: cfergeau at redhat dot com CC: libabigail at sourceware dot org Target Milestone: --- I tried to compare https://koji.fedoraproject.org/koji/buildinfo?buildID=3D673437 and https://koji.fedoraproject.org/koji/buildinfo?buildID=3D689970 using $ abipkgdiff --d1 ./spice-debuginfo-0.12.5-9.fc24.x86_64.rpm --d2 ./spice-debuginfo-0.12.6-1.fc24.x86_64.rpm --devel1 ./spice-server-devel-0.12.5-9.fc24.x86_64.rpm --devel2 ./spice-server-devel-0.12.6-1.fc24.x86_64.rpm ./spice-server-0.12.5-9.fc24.x86_64.rpm=20 ./spice-server-0.12.6-1.fc24.x86_64.rpm (libabigail-1.0-0.8.rc6.4.fc25.x86_64) The result is 2 functions with some indirect sub-type change: [C]'function spice_image_compression_t spice_server_get_image_compression()' at reds.c:3578:1 has some indirect sub-type changes: return type changed: entity changed from 'typedef spice_image_compression_t' to 'void' type size changed from 32 to 0 bits type alignment changed from 32 to 0 bits [C]'function int spice_server_set_image_compression(spice_image_compression_t)' at reds.c:35= 62:1 has some indirect sub-type changes: parameter 1 of type 'typedef spice_image_compression_t' was removed The corresponding headers are: in 0.12.5: typedef enum { SPICE_IMAGE_COMPRESS_INVALID =3D 0, SPICE_IMAGE_COMPRESS_OFF =3D 1, SPICE_IMAGE_COMPRESS_AUTO_GLZ =3D 2, SPICE_IMAGE_COMPRESS_AUTO_LZ =3D 3, SPICE_IMAGE_COMPRESS_QUIC =3D 4, SPICE_IMAGE_COMPRESS_GLZ =3D 5, SPICE_IMAGE_COMPRESS_LZ =3D 6, } spice_image_compression_t; int spice_server_set_image_compression(SpiceServer *s, spice_image_compression_t comp); spice_image_compression_t spice_server_get_image_compression(SpiceServer *s= ); in 0.12.6: // Needed for backward API compatibility typedef SpiceImageCompression spice_image_compression_t; #define SPICE_IMAGE_COMPRESS_INVALID SPICE_IMAGE_COMPRESSION_INVALID #define SPICE_IMAGE_COMPRESS_OFF SPICE_IMAGE_COMPRESSION_OFF #define SPICE_IMAGE_COMPRESS_AUTO_GLZ SPICE_IMAGE_COMPRESSION_AUTO_GLZ #define SPICE_IMAGE_COMPRESS_AUTO_LZ SPICE_IMAGE_COMPRESSION_AUTO_LZ #define SPICE_IMAGE_COMPRESS_QUIC SPICE_IMAGE_COMPRESSION_QUIC #define SPICE_IMAGE_COMPRESS_GLZ SPICE_IMAGE_COMPRESSION_GLZ #define SPICE_IMAGE_COMPRESS_LZ SPICE_IMAGE_COMPRESSION_LZ #define SPICE_IMAGE_COMPRESS_LZ4 SPICE_IMAGE_COMPRESSION_LZ4 int spice_server_set_image_compression(SpiceServer *s, SpiceImageCompression comp); SpiceImageCompression spice_server_get_image_compression(SpiceServer *s); The 'spice_image_compression_t' used to be defined in a header part of spice-server, but with the 0.12.6, this is no longer the case, it's now def= ined outside of this source RPM (in spice-protocol). However, the change should be API/ABI compatible, so it's unexpected to have abipkgdiff complain about it, especially saying that the spice_image_compression_t arg/return value was removed while it's still the= re. The second issue is that the SpiceServer argument to these functions do not appear in the output produced by abipkgdiff, it only kept the spice_image_compression_t argument --=20 You are receiving this mail because: You are on the CC list for the bug.