[Bug default/21153] New: abipkgdiff aborts with error message"Assertion `get_type_diff() && get_type_diff()->to_be_reported()

[Bug default/21153] New: abipkgdiff aborts with error message"Assertion `get_type_diff() && get_type_diff()->to_be_reported()

[sinny at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21153

            Bug ID: 21153
           Summary: abipkgdiff aborts with error message"Assertion
                    `get_type_diff() && get_type_diff()->to_be_reported()
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: sinny at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 9821
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9821&action=edit
gdb backtrace

Running abipkgdiff on package libcdio gets aborted with error message -
Assertion `get_type_diff() && get_type_diff()->to_be_reported()' failed

Packages used
-------------

p1 -
https://kojipkgs.fedoraproject.org//packages/libcdio/0.94/1.fc26/x86_64/libcdio-0.94-1.fc26.x86_64.rpm
d1 -
https://kojipkgs.fedoraproject.org//packages/libcdio/0.94/1.fc26/x86_64/libcdio-debuginfo-0.94-1.fc26.x86_64.rpm
p1 -
https://kojipkgs.fedoraproject.org//packages/libcdio/0.94/2.fc26/x86_64/libcdio-0.94-2.fc26.x86_64.rpm
d1 -
https://kojipkgs.fedoraproject.org//packages/libcdio/0.94/2.fc26/x86_64/libcdio-debuginfo-0.94-2.fc26.x86_64.rpm

Running abipkgdiff on above packages:
---------------------------------------
$ abipkgdiff  --d1 libcdio-debuginfo-0.94-1.fc26.x86_64.rpm --d2
libcdio-debuginfo-0.94-2.fc26.x86_64.rpm libcdio-0.94-1.fc26.x86_64.rpm
libcdio-0.94-2.fc26.x86_64.rpm 
lt-abipkgdiff: ../../src/abg-comparison.cc:8432: virtual void
abigail::comparison::fn_parm_diff::report(std::ostream&, const string&) const:
Assertion `get_type_diff() && get_type_diff()->to_be_reported()' failed.

gdb backtrace is available in bugzilla attachment

Version of libabigail used - master branch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21153] abipkgdiff aborts with error message"Assertion `get_type_diff() && get_type_diff()->to_be_reported()

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21153

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from dodji at redhat dot com ---
It seems the current master branch doesn't have this crash any more.

Though, abipkgdiff seems to exhibit an issue.  it says the libcdio.so.16.0.0
binary has interfaces subtype changes, but it won't be able to describe those
subtype changes.

That issue is the one I am going to be fixing now.

Here the command line and the problems:

$ ~/git/libabigail/master/build/tools/abipkgdiff --d1
libcdio-debuginfo-0.94-1.fc26.x86_64.rpm --d2
libcdio-debuginfo-0.94-2.fc26.x86_64.rpm libcdio-0.94-1.fc26.x86_64.rpm 
libcdio-0.94-2.fc26.x86_64.rpm 
[...]
================ changes of 'libcdio++.so.0.0.2'===============
  Functions changes summary: 0 Removed, 4 Changed, 0 Added functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  4 functions with some indirect sub-type change:

    [C]'function void closeTray(const char*, driver_id_t&)' at devices.cpp:38:1
has some indirect sub-type changes:

    [C]'function char* getDefaultDevice(driver_id_t&)' at devices.cpp:102:1 has
some indirect sub-type changes:

    [C]'function char** getDevices(char**, cdio_fs_anal_t, driver_id_t&, bool)'
at devices.cpp:168:1 has some indirect sub-type changes:

    [C]'function char** getDevices(driver_id_t&)' at devices.cpp:132:1 has some
indirect sub-type changes:


================ end of changes of 'libcdio++.so.0.0.2'===============


$

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21153] abipkgdiff reports undetermined interface subtype changes

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21153

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|abipkgdiff aborts with      |abipkgdiff reports
                   |error message"Assertion     |undetermined interface
                   |`get_type_diff() &&         |subtype changes
                   |get_type_diff()->to_be_repo |
                   |rted()                      |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21153] abipkgdiff reports undetermined interface subtype changes

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21153

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
The fix for this problem has been committed at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=2e2c5ff1cb44b23755cfe00ad931b48917fc6d3a,
in the master branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.