From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/21263] New: Provide finer redundant type detection from DWARF
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <bug-21263-9487@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=21263
Bug ID: 21263
Summary: Provide finer redundant type detection from DWARF
Product: libabigail
Version: unspecified
Status: NEW
Severity: enhancement
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: dodji at redhat dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
When analyzing C binaries, the redundant type detector only looks at the kind
of the type, its name and its location.
That is, if a struct named foo and defined at file blah.c, line 5 column 1 is
seen twice, the second occurrence of that type is considered to be a duplicate
of the first one. So the internal representation of the first occurrence of
the type is re-used instead of constructing an internal representation for the
second type as well.
But then, it can happen that the first struct foo defined in file blah.c:5:1 is
*different* (has a different layout, size or whatever) from the second
occurrence of foo defined at the *same* location.
In that case, today, libabigail wrongly drops the second occurrence.
The goal of this enhancement request is to improve the redundant type detector
to make it actually compare the DIEs of the two "struct foo", to see if they
are equal.
The redundant type detector would still index those types using their name and
kind. But it would associate the name of the type to a vector of types having
the same name.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2017-03-17 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 dodji at redhat dot com [this message]
2017-01-01 0:00 ` [Bug default/21263] " dodji at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-21263-9487@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).