From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/21296] abidiff reports possibly bogus differences and crashes
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <bug-21296-9487-dU1rVwZ8EB@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-21296-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=21296
Ben Woodard <woodard at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |woodard at redhat dot com
--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
jwakely and I were discussing this, this morning.
We think that there are actually three problems:
1) the abidiff crash
2) the second changed function seems to only be different with regards to
whitespace. We think that whitespace differences should be ignored. Can you
make the evaluative function ignore the change in the whitespace.
3) libabigail seems to miss the true nature of the ABI change which is that one
of the parameters is passed on the stack while the other is passed on a
register. We believe that GCC implements the correct calling convention
according to the Itanium C++ ABI.
See: https://bugs.llvm.org//show_bug.cgi?id=23034 I haven't looked at the DWARF
yet but jwakely seemed to say that he wasn't surprised that libabigail missed
detecting this ABI change because the DWARF was insufficient. If that is in
fact the case, then we probably need to file a couple of BZ's to improve the
DWARF on GCC and CLAMG so that libabigail has the information needed to address
this.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2017-03-23 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 [Bug default/21296] New: " jwakely.gcc at gmail dot com
2017-01-01 0:00 ` [Bug default/21296] naive comparison of names of template instantiations leads to false postives dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21296] New: abidiff reports possibly bogus differences and crashes Dodji Seketeli
2017-01-01 0:00 ` [Bug default/21296] naive comparison of names of template instantiations leads to false postives dodji at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com [this message]
2017-01-01 0:00 ` [Bug default/21296] abidiff reports possibly bogus differences and crashes dodji at seketeli dot org
2020-11-12 14:30 ` [Bug default/21296] naive comparison of names of template instantiations leads to false postives maennich at android dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-21296-9487-dU1rVwZ8EB@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).