From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <bug-21486-9487-bOomEOU2aK@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-21486-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=21486
--- Comment #9 from dodji at redhat dot com ---
I started to hack on this. I am categorizing changes in which top-level const
qualifiers of function parameter types as being harmless. As a result, those
changes are filtered out (by default) by libabigail. Note that users can still
see those harmless changes by doing using the --harmless option of abidiff.
Looking at the result of comparing the two attached binaries, it appears to me
that there are other things (not related to the title of this opened bug) to
fix, so that abidiff concludes that the two binaries have equivalent ABIs.
Ideally, I'd thus have to construct smaller test cases that expose the problems
separately. That way, I can use each of the small test cases as regression
tests in each of the patches that resolve the problem they expose.
I should thus build a version of Clang that exhibits those issues and maybe
file separate bugs for the issues I am seeing.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2017-06-07 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 [Bug default/21486] New: missing const when comparing C++ object files woodard at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com [this message]
2017-01-01 0:00 ` Dodji Seketeli
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored dodji at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] missing const when comparing C++ object files dodji at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] missing const when comparing C++ object files woodard at redhat dot com
2017-01-01 0:00 ` dodji at seketeli dot org
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] missing const when comparing C++ object files woodard at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-21486-9487-bOomEOU2aK@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).