From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <bug-21486-9487-udgGDmGAll@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-21486-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=21486
--- Comment #11 from dodji at redhat dot com ---
This issue is addressed in the dodji/kabidiff branch by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=56be011037bdca65ca965755aa2241a548c4398e.
In particular, that patch makes libabigail filter out changes about top
const/volatile qualifiers of function parameter types because they are now
considered as being harmless.
Users can still see those changes, should they want to do so, (as those changes
might have API consequences, even if they are not harmful as far as ABI is
concerned) if they use the --harmless option of abidiff.
Please note however that for abidiff to consider that the two binaries
(attached to this bug) have no functions sub-type changes, 3 patches are
needed, including the one cited above. They are all present in the
dodji/kabidiff branch:
08d1fa8 Symbols with the same zero value are not aliases
8c48e8d Support ELF symbol visibility property
56be011 Filter top cv qualifier changes on function parameter types
Please note that this branch is soon going to be merged in the master branch. I
will thus close the bug when that merge happens.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2017-06-13 14:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 [Bug default/21486] New: missing const when comparing C++ object files woodard at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] missing const when comparing C++ object files woodard at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` dodji at seketeli dot org
2017-01-01 0:00 ` dodji at redhat dot com [this message]
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored woodard at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] New: missing const when comparing C++ object files Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-21486-9487-udgGDmGAll@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).