From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38245 invoked by alias); 13 Jun 2017 14:32:24 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 38124 invoked by uid 48); 13 Jun 2017 14:32:18 -0000 From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored Date: Sun, 01 Jan 2017 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q2/txt/msg00049.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D21486 --- Comment #11 from dodji at redhat dot com --- This issue is addressed in the dodji/kabidiff branch by commit https://sourceware.org/git/gitweb.cgi?p=3Dlibabigail.git;a=3Dcommit;h=3D56b= e011037bdca65ca965755aa2241a548c4398e. In particular, that patch makes libabigail filter out changes about top const/volatile qualifiers of function parameter types because they are now considered as being harmless. Users can still see those changes, should they want to do so, (as those cha= nges might have API consequences, even if they are not harmful as far as ABI is concerned) if they use the --harmless option of abidiff. Please note however that for abidiff to consider that the two binaries (attached to this bug) have no functions sub-type changes, 3 patches are needed, including the one cited above. They are all present in the dodji/kabidiff branch: 08d1fa8 Symbols with the same zero value are not aliases 8c48e8d Support ELF symbol visibility property 56be011 Filter top cv qualifier changes on function parameter types Please note that this branch is soon going to be merged in the master branc= h. I will thus close the bug when that merge happens. --=20 You are receiving this mail because: You are on the CC list for the bug.