From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/21486] New: missing const when comparing C++ object files
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <bug-21486-9487@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=21486
Bug ID: 21486
Summary: missing const when comparing C++ object files
Product: libabigail
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: woodard at redhat dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
Doing some introspection on libabigail itself with different compilers it flags
this error:
[C]'function void abigail::dump(abigail::ir::translation_unit_sptr,
std::ostream&, bool)' at abg-writer.cc:4091:1 has some indirect sub-type
changes:
parameter 1 of type 'typedef abigail::ir::translation_unit_sptr' changed:
entity changed from 'typedef abigail::ir::translation_unit_sptr' to
'const abigail::ir::translation_unit_sptr'
type size hasn't changed
parameter 3 of type 'bool' changed:
entity changed from 'bool' to 'const bool'
type size hasn't changed
[ben@localhost build]$ g++ --version
g++ (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[ben@localhost build]$ clang++ --version
clang version 3.9.1 (tags/RELEASE_391/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
The function definition does seem to have a const:
void
dump(const translation_unit_sptr t, std::ostream& o, const bool annotate)
{
if (t)
dump(*t, o, annotate);
}
digging through the readelf output it looks like it is a libabigail bug:
GCC's debug-info looks correct:
[ 41147] subprogram
external (flag_present) yes
name (strp) "dump"
decl_file (data1) 2
decl_line (data2) 4069
linkage_name (strp)
"abigail::dump(abigail::ir::translation_unit const&, std::basic_ostream<char,
std::char_traits<char> >&, bool)"
declaration (flag_present) yes
sibling (ref4) [ 41167]
[ 41157] formal_parameter
type (ref4) [ 6b4b9]
[ 4115c] formal_parameter
type (ref4) [ 42e87]
[ 41161] formal_parameter
type (ref4) [ 3c1a1]
[ 6b4b9] reference_type
byte_size (data1) 8
type (ref4) [ 3d90e]
[ 3d90e] const_type
type (ref4) [ 3d7dd]
[ 3d7dd] class_type
name (strp) "translation_unit"
declaration (flag_present) yes
sibling (ref4) [ 3d90e]
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2017-05-12 1:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 woodard at redhat dot com [this message]
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored woodard at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] New: missing const when comparing C++ object files Dodji Seketeli
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored dodji at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] missing const when comparing C++ object files woodard at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` dodji at seketeli dot org
2017-01-01 0:00 ` woodard at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] top-level const qualifiers on types of function parameters are not ignored dodji at redhat dot com
2017-01-01 0:00 ` [Bug default/21486] missing const when comparing C++ object files dodji at redhat dot com
2017-01-01 0:00 ` dodji at redhat dot com
2017-01-01 0:00 ` woodard at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-21486-9487@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).