[Bug default/21627] New: [kabidiff branch] fedabipkgdiff fails on gnupg package for fc25

[Bug default/21627] New: [kabidiff branch] fedabipkgdiff fails on gnupg package for fc25

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

            Bug ID: 21627
           Summary: [kabidiff branch] fedabipkgdiff fails on gnupg package
                    for fc25
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

On the dodji/kabidiff branch the command below fails:

$ time fedabipkgdiff --self-compare --from fc25 gnupg
Comparing the ABI of binaries between gnupg-1.4.21-1.fc25.armv7hl.rpm and
gnupg-1.4.21-1.fc25.armv7hl.rpm:

abipkgdiff:
/home/dodji/git/libabigail/kabidiff-with-fixes/src/abg-corpus.cc:547: void
abigail::ir::corpus::add(abigail::ir::translation_unit_sptr): Assertion `i ==
priv_->path_tu_map.end()' failed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21627] [kabidiff branch] fedabipkgdiff fails on gnupg package for fc25

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Just a FYI in my test data set there are 37 cases of this out of 797 packages
tested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21627] [kabidiff branch] Libabigail doesn't take translation unit compile dir into account

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[kabidiff branch]           |[kabidiff branch]
                   |fedabipkgdiff fails on      |Libabigail doesn't take
                   |gnupg package for fc25      |translation unit compile
                   |                            |dir into account

--- Comment #3 from dodji at redhat dot com ---
The problem here is due to the fact that the path of a translation unit is
relative to the directory where that translation unit was compiled.

So there can be several different translation units (in the same binary) that
have the same (relative) paths.  To tell them apart, one needs to consider the
compile directory of those translation units.

But then Libabigail ignores the compilation directory of translation units.  It
just considers their (relative) path.  That leads to different translation
units having the same path.  Oops.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21627] Libabigail doesn't take translation unit compile dir into account

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from dodji at redhat dot com ---
This problem should now be fixed in the dodji/kabidiff  branch by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=2f070edf6c6039f87b8510918062ff5b63cf38c4.

I am thus closing this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21627] Libabigail doesn't take translation unit compile dir into account

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[kabidiff branch]           |Libabigail doesn't take
                   |Libabigail doesn't take     |translation unit compile
                   |translation unit compile    |dir into account
                   |dir into account            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21627] [kabidiff branch] fedabipkgdiff fails on gnupg package for fc25

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21628


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=21628
[Bug 21628] Fix libabigail bugs on dodji/kabidiff branch when running
fedabipkgdiff --self-compare
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21627] [kabidiff branch] fedabipkgdiff fails on gnupg package for fc25

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21627

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |woodard at redhat dot com

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
*** Bug 21642 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.