[Bug default/21629] [dodji/kabidiff branch] Libabigail fails to ensure that two equivalent DIEs must be of the same DIE source

[Bug default/21629] [dodji/kabidiff branch] Libabigail fails to ensure that two equivalent DIEs must be of the same DIE source

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21629

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|[dodji/kabidiff branch]     |[dodji/kabidiff branch]
                   |fedabipkgdiff fails on      |Libabigail fails to ensure
                   |evolution-data-server in    |that two equivalent DIEs
                   |fc25                        |must be of the same DIE
                   |                            |source

--- Comment #1 from dodji at redhat dot com ---
A prerequisite to represent the relationship "DIE 'D' has canonical DIE C", is
that D and C come from the same DIE source.  A DIE source being either the main
debug info file, the alternate debug info file (both having DIEs in their
.debug_info section), or a .debug_type section.

This prerequisite is a result of the design of the current libabigail's DWARF
reader.

The problem in this issue is that the code that compares DIEs and that updates
the canonical DIEs of the compared DIEs (in case the two DIEs are equivalent)
sometimes fails to honour that prerequisite, causing other troubles down the
road.  This is in the compare_dies function, in abg-dwarf-reader.cc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21629] New: [dodji/kabidiff branch] fedabipkgdiff fails on evolution-data-server in fc25

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21629

            Bug ID: 21629
           Summary: [dodji/kabidiff branch] fedabipkgdiff fails on
                    evolution-data-server in fc25
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

$ time fedabipkgdiff --self-compare --from fc25 evolution-data-server
Comparing the ABI of binaries between
evolution-data-server-3.22.7-2.fc25.armv7hl.rpm and
evolution-data-server-3.22.7-2.fc25.armv7hl.rpm:

abipkgdiff:
/home/dodji/git/libabigail/kabidiff-with-fixes/src/abg-dwarf-reader.cc:4000:
void
abigail::dwarf_reader::read_context::get_die_from_offset(abigail::dwarf_reader::die_source,
                                                         Dwarf_Off,
                                                         Dwarf_Die*) const:
Assertion `dwarf_offdie(dwarf_per_die_source(source), offset,die)' failed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21629] [dodji/kabidiff branch] Libabigail fails to ensure that two equivalent DIEs must be of the same DIE source

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21629

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
This should be fixed on the dodji/kabidiff branch by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=92cc3c52e8680e433c44803956fa1434e320f789.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21629] [dodji/kabidiff branch] fedabipkgdiff fails on evolution-data-server in fc25

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21629

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21628


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=21628
[Bug 21628] Fix libabigail bugs on dodji/kabidiff branch when running
fedabipkgdiff --self-compare
-- 
You are receiving this mail because:
You are on the CC list for the bug.