[Bug default/21772] ignore whitespace changes when comparing names:

["woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=21772

--- Comment #8 from Ben Woodard <woodard at redhat dot com> ---
Dodji, I know that we discussed this in chat and you pointed out that it was
test2 that was wrong rather than test1 and that it was considering something
harmless which wasn't but I can't recall what that was. Can you explain it
again?

[ben@localhost c++test]$ abidiff --no-unreferenced-symbols --harmless test2.o
test2-clang.o 
Functions changes summary: 0 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 1 Changed, 0 Added variable

1 Changed variable:

  [C]'A<int, int*> i' was changed to 'A<int, int *> i' at test2.cpp:6:1:
    type of variable changed:
     type name changed from 'A<int, int*>' to 'A<int, int *>'
     type size hasn't changed

     2 data member changes:
      name of 'A<int, int*>::a' changed to 'A<int, int *>::a' at test2.cpp:2:1
      name of 'A<int, int*>::b' changed to 'A<int, int *>::b' at test2.cpp:3:1


[ben@localhost c++test]$ cat test2.
test2.cpp  test2.o    
[ben@localhost c++test]$ cat test2.cpp 
template <typename T, typename U = T*> struct A {
  T a;
  U b;
};

A<int> i;

I recognize that 21296 is the issue regarding normalizing types which appears
in the typenames but I don't see in this case why considering this change
harmless is a problem. I think you said that it was because it was considered
harmless for the wrong reason but I don't recall what you said was the reason.

-- 
You are receiving this mail because:
You are on the CC list for the bug.