From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58904 invoked by alias); 26 Jul 2017 18:18:30 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 58758 invoked by uid 48); 26 Jul 2017 18:18:20 -0000 From: "woodard at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/21772] ignore whitespace changes when comparing names: Date: Sun, 01 Jan 2017 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: woodard at redhat dot com X-Bugzilla-Status: REOPENED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q3/txt/msg00030.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D21772 --- Comment #8 from Ben Woodard --- Dodji, I know that we discussed this in chat and you pointed out that it was test2 that was wrong rather than test1 and that it was considering something harmless which wasn't but I can't recall what that was. Can you explain it again? [ben@localhost c++test]$ abidiff --no-unreferenced-symbols --harmless test2= .o test2-clang.o=20 Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables changes summary: 0 Removed, 1 Changed, 0 Added variable 1 Changed variable: [C]'A i' was changed to 'A i' at test2.cpp:6:1: type of variable changed: type name changed from 'A' to 'A' type size hasn't changed 2 data member changes: name of 'A::a' changed to 'A::a' at test2.cpp:= 2:1 name of 'A::b' changed to 'A::b' at test2.cpp:= 3:1 [ben@localhost c++test]$ cat test2. test2.cpp test2.o=20=20=20=20 [ben@localhost c++test]$ cat test2.cpp=20 template struct A { T a; U b; }; A i; I recognize that 21296 is the issue regarding normalizing types which appea= rs in the typenames but I don't see in this case why considering this change harmless is a problem. I think you said that it was because it was consider= ed harmless for the wrong reason but I don't recall what you said was the reas= on. --=20 You are receiving this mail because: You are on the CC list for the bug.