[Bug default/22160] Annotate state flag unitialized in abidw

[Bug default/22160] Annotate state flag unitialized in abidw

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22160

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
The fixlet for this issue was committed to the master branch of the git
repository at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=8edaadb5f6ec733694d1476f094aa979a28b3712.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/22160] Annotate state flag unitialized in abidw

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22160

--- Comment #1 from dodji at redhat dot com ---
"andrew.c.morrow at gmail dot com" <sourceware-bugzilla@sourceware.org>
writes:

> If the --annotate flag is explicitly provided, this does not reproduce. I
> suspect an uninitialized variable somewhere.

And you are so right, Andrew.

Just reading the construction of the "options" class in abidw.cc shows
that we forgot to initialize the "annotate" data member in there.
Excellent catch.

I'll push a fix for this as soon as "make distcheck" finishes.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/22160] Annotate state flag unitialized in abidw

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22160

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2017-09-21
            Summary|abidw annotation state      |Annotate state flag
                   |seems non-deterministic     |unitialized in abidw
     Ever confirmed|0                           |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/22160] New: abidw annotation state seems non-deterministic

[andrew.c.morrow at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22160

            Bug ID: 22160
           Summary: abidw annotation state seems non-deterministic
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: andrew.c.morrow at gmail dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Without changing the contents of the file, repeated executions of abidw give
inconsistent output. This output is apparently the result of enabling the
--annotate flag

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
440d439
<     <!-- _fini -->
442d440
<     <!-- _init -->

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)

$ diff <(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
<(/home/andrew/opt/bin/abidw build/cached/mongo/db/libserveronly.so)
440d439
<     <!-- _fini -->
442d440
<     <!-- _init -->


If the --annotate flag is explicitly provided, this does not reproduce. I
suspect an uninitialized variable somewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.