public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
@ 2017-01-01  0:00 sinny at redhat dot com
  2017-01-01  0:00 ` [Bug default/22428] " dodji at redhat dot com
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: sinny at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428

            Bug ID: 22428
           Summary: Running abidiff on binary icuinfo from icu package
                    aborts with message Assertion `result' failed
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: sinny at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 10586
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10586&action=edit
icuinfo backtrace

Running abidiff on icuinfo binary aborts with following message:

abidiff: ../../src/abg-dwarf-reader.cc:13515:
abigail::ir::pointer_type_def_sptr
abigail::dwarf_reader::build_pointer_type_def(abigail::dwarf_reader::read_context&,
Dwarf_Die*, bool, size_t): Assertion `result' failed.
Aborted (core dumped)

Complete backtrace is available in the attachment.

Steps to reproduce
------------------

Download following packages:

libicu-devel -
https://kojipkgs.fedoraproject.org//packages/icu/57.1/9.fc27/ppc64/libicu-devel-57.1-9.fc27.ppc64.rpm
libicu-devel-debuginfo -
https://kojipkgs.fedoraproject.org//packages/icu/57.1/9.fc27/ppc64/libicu-devel-debuginfo-57.1-9.fc27.ppc64.rpm

Extract rpm and corresponding debuginfo rpm and run abidiff command on binary
icuinfo

$ abidiff --d1 libicu-devel-debug/usr/lib/debug/ --d2
libicu-devel-debug/usr/lib/debug/ libicu-devel/usr/bin/icuinfo
libicu-devel/usr/bin/icuinfo

abidiff: ../../src/abg-dwarf-reader.cc:13515:
abigail::ir::pointer_type_def_sptr
abigail::dwarf_reader::build_pointer_type_def(abigail::dwarf_reader::read_context&,
Dwarf_Die*, bool, size_t): Assertion `result' failed.
Aborted (core dumped)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
                   ` (4 preceding siblings ...)
  2017-01-01  0:00 ` dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from dodji at redhat dot com ---
To provide some perspective, I'd like to add that this issue is visible with
abipkgdiff when used to compare libicu-devel-57.1-9.fc27.ppc64.rpm  against
itself.

abipkgdiff --d1 libicu-devel-debuginfo-57.1-9.fc27.ppc64.rpm \
           --d2 libicu-devel-debuginfo-57.1-9.fc27.ppc64.rpm\
                libicu-devel-57.1-9.fc27.ppc64.rpm \
                libicu-devel-57.1-9.fc27.ppc64.rpm

I believe it's an easier way to reproduce and (hopefully) debug the issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22436, 22437, 22438

--- Comment #2 from dodji at redhat dot com ---
I think the root cause of this issue is that
libicu-devel-debuginfo-57.1-9.fc27.ppc64.rpm is not enough to carry all the
debug info needed by the icuinfo binary carried by
libicu-devel-57.1-9.fc27.ppc64.rpm.

THe icuinfo binary actually needs *both* the
libicu-devel-debuginfo-57.1-9.fc27.ppc64.rpm *and*
icu-debuginfo-57.1-9.fc27.ppc64.rpm.

As a matter of fact, if you extract both
libicu-devel-debuginfo-57.1-9.fc27.ppc64.rpm and
icu-debuginfo-57.1-9.fc27.ppc64.rpm (and not just the former), then invoking
abidiff as in the initial example of this problem report just works fine.

To solve this issue, we need to:

1/ make abipkgdiff allow more than one debuginfo package per package to
compare.  This is tracked by #22436.

2/ make fedabipkgdiff systematically use the debug info package of the "main"
package, when it's looking at sub-package. Of course, the tool should also use
the specific debug info sub-package, if there is any.  That is, fedabipkgdiff
should be able to handle more than one debuginfo package per package to
compare.
This is tracked by #22437.

3/ make abidiff/abipkgdiff emit a clearer error message when a dependant debug
information file is not found. This is tracked by #22438


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=22436
[Bug 22436] make abipkgdiff accept several debuginfo packages per package to
compare
https://sourceware.org/bugzilla/show_bug.cgi?id=22437
[Bug 22437] Make fedabipkgdiff use all debug info packages of a given
sub-package
https://sourceware.org/bugzilla/show_bug.cgi?id=22438
[Bug 22438] Emit a clear message when the debug info file referred to by a
binary is not found.
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
                   ` (3 preceding siblings ...)
  2017-01-01  0:00 ` dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from dodji at redhat dot com ---
Points 1/, 2/ and 3/ have been addressed separately.

I think we can now assume that this annoying issue (on ppc64) is now solved in
the master branch and the fix will be available in the coming 1.1 release of
libabigail.

Thank you for filing this bug!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
  2017-01-01  0:00 ` [Bug default/22428] " dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428
Bug 22428 depends on bug 22436, which changed state.

Bug 22436 Summary: make abipkgdiff accept several debuginfo packages per package to compare
https://sourceware.org/bugzilla/show_bug.cgi?id=22436

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
                   ` (2 preceding siblings ...)
  2017-01-01  0:00 ` dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428
Bug 22428 depends on bug 22437, which changed state.

Bug 22437 Summary: Make fedabipkgdiff use all debug info packages of a given sub-package
https://sourceware.org/bugzilla/show_bug.cgi?id=22437

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
  2017-01-01  0:00 ` [Bug default/22428] " dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  2017-01-01  0:00 ` dodji at redhat dot com
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428

--- Comment #3 from dodji at redhat dot com ---
*** Bug 22427 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug default/22428] Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed
  2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
                   ` (5 preceding siblings ...)
  2017-01-01  0:00 ` dodji at redhat dot com
@ 2017-01-01  0:00 ` dodji at redhat dot com
  6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2017-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=22428
Bug 22428 depends on bug 22438, which changed state.

Bug 22438 Summary: Emit a clear message when the debug info file referred to by a binary is not found.
https://sourceware.org/bugzilla/show_bug.cgi?id=22438

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-12-15 15:45 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-01  0:00 [Bug default/22428] New: Running abidiff on binary icuinfo from icu package aborts with message Assertion `result' failed sinny at redhat dot com
2017-01-01  0:00 ` [Bug default/22428] " dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com
2017-01-01  0:00 ` dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).