[Bug default/22488] abipkgdiff sometimes compares with wrong elf file when multiple elf files with same name are available in a package

[Bug default/22488] abipkgdiff sometimes compares with wrong elf file when multiple elf files with same name are available in a package

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22488

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
This should now be fixed in the master branch by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=8028cdd236eae10cf35faefd823af071da2dbb3f.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/22488] New: abipkgdiff sometimes compares with wrong elf file when multiple elf files with same name are available in a package

[sinny at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22488

            Bug ID: 22488
           Summary: abipkgdiff sometimes compares with wrong elf file when
                    multiple elf files with same name are available in a
                    package
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: sinny at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

It looks like abipkgdiff tool doesn't take into account relative elf file path
while doing ABI comparison on a binary file available in two packages to be
compared. Due to this, abipkgdiff may show false positive ABI changes if a
package has multiple binaries with same name.

For example:
We have seen false positive result in task-abicheck run on php-odbc sub-package
from php -
https://taskotron.fedoraproject.org/artifacts/all/3dd146e8-cf54-11e7-a1d7-525400817a8f/task_output/php-7.1.12-1.fc27.log 

* Incompatible ABI changes between php-odbc-7.1.11-1.fc27.i686.rpm and
php-odbc-7.1.12-1.fc27.i686.rpm. ABI comparison took 0.56 second(s). Please
review them.

================ changes of 'odbc.so'===============
  Functions changes summary: 0 Removed, 0 Changed, 0 Added function
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
  Function symbols changes summary: 0 Removed, 0 Added function symbol not
referenced by debug info
  Variable symbols changes summary: 1 Removed, 1 Added variable symbols not
referenced by debug info

  1 Removed variable symbol not referenced by debug info:

    odbc_globals

  1 Added variable symbol not referenced by debug info:

    odbc_globals_id

================ end of changes of 'odbc.so'===============


When  we look inside one of php-odbc sub-package(
https://kojipkgs.fedoraproject.org//packages/php/7.1.11/1.fc27/i686/php-odbc-7.1.11-1.fc27.i686.rpm
), it contains twice odbc.so library in same package.

$ ls php-odbc-7.1.11-1/usr/lib/php/modules/
odbc.so  pdo_odbc.so
$ ls usr/lib/php-zts/modules/
odbc.so  pdo_odbc.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.