From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9569 invoked by alias); 24 Nov 2017 09:28:27 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 8989 invoked by uid 48); 24 Nov 2017 09:28:18 -0000 From: "sinny at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/22488] New: abipkgdiff sometimes compares with wrong elf file when multiple elf files with same name are available in a package Date: Sun, 01 Jan 2017 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: sinny at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q4/txt/msg00036.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D22488 Bug ID: 22488 Summary: abipkgdiff sometimes compares with wrong elf file when multiple elf files with same name are available in a package Product: libabigail Version: unspecified Status: NEW Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: sinny at redhat dot com CC: libabigail at sourceware dot org Target Milestone: --- It looks like abipkgdiff tool doesn't take into account relative elf file p= ath while doing ABI comparison on a binary file available in two packages to be compared. Due to this, abipkgdiff may show false positive ABI changes if a package has multiple binaries with same name. For example: We have seen false positive result in task-abicheck run on php-odbc sub-pac= kage from php - https://taskotron.fedoraproject.org/artifacts/all/3dd146e8-cf54-11e7-a1d7-5= 25400817a8f/task_output/php-7.1.12-1.fc27.log=20 * Incompatible ABI changes between php-odbc-7.1.11-1.fc27.i686.rpm and php-odbc-7.1.12-1.fc27.i686.rpm. ABI comparison took 0.56 second(s). Please review them. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D changes of 'odbc.so'=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable Function symbols changes summary: 0 Removed, 0 Added function symbol not referenced by debug info Variable symbols changes summary: 1 Removed, 1 Added variable symbols not referenced by debug info 1 Removed variable symbol not referenced by debug info: odbc_globals 1 Added variable symbol not referenced by debug info: odbc_globals_id =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D end of changes of 'odbc.so= '=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D When we look inside one of php-odbc sub-package( https://kojipkgs.fedoraproject.org//packages/php/7.1.11/1.fc27/i686/php-odb= c-7.1.11-1.fc27.i686.rpm ), it contains twice odbc.so library in same package. $ ls php-odbc-7.1.11-1/usr/lib/php/modules/ odbc.so pdo_odbc.so $ ls usr/lib/php-zts/modules/ odbc.so pdo_odbc.so --=20 You are receiving this mail because: You are on the CC list for the bug.