[Bug default/22913] New: Libabigail mishandles de-duplication of pointers to anonymous structs inside a given translation unit

[Bug default/22913] New: Libabigail mishandles de-duplication of pointers to anonymous structs inside a given translation unit

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22913

            Bug ID: 22913
           Summary: Libabigail mishandles de-duplication of pointers to
                    anonymous structs inside a given translation unit
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Consider the sequence of work below where we try to compare the two binaries
libt0.s and libt1.so below:

$ cat t0.c
typedef struct
{
  char m0;                                                                      
} * Struct0Ptr;                                                                 

char
f0(Struct0Ptr s)
{return s->m0;}                                                                 

typedef struct
{
  char m1;                                                                      
  char m2;                                                                      
} * Struct1Ptr;                                                                 

char
f1(Struct1Ptr s)
{return s->m1;}                                                                 
$
$ cat t1.c
typedef struct
{
  char m0;                                                                      
} * Struct0Ptr;                                                                 

char
f0(Struct0Ptr s)
{return s->m0;}                                                                 

typedef struct
{
  char m1;                                                                      
} * Struct1Ptr;                                                                 

char
f1(Struct1Ptr s)
{return s->m1;}                                                                 
$ gcc -g -shared -o libt0.so t0.c
$ gcc -g -shared -o libt1.so t1.c
$ ~/git/libabigail/master/build/tools/abidiff libt0.so libt1.so
$

Here, we should have had a change reported between the two versions of f1
because the type Struct1Ptr changed.  But abidiff reports no change.

This is because all the anonymous types are wrongly being considered equal
because of a mis-optimization during canonicalization of their DWARF type DIEs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/22913] Libabigail mishandles de-duplication of pointers to anonymous structs inside a given translation unit

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22913

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
This should be fixed in the master branch of the git repository at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=30314e3a62d15055a4fb484c690840318efcf946
and should be available in the 1.2 release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.