public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/23492] New: Support analysing libgfortran.so
@ 2018-01-01  0:00 dodji at redhat dot com
  2018-01-01  0:00 ` [Bug default/23492] " bochecha at daitauha dot fr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2018-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=23492

            Bug ID: 23492
           Summary: Support analysing libgfortran.so
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

The fine folks behind the freedesktop-sdk flatpak effort stumbled upon abidiff
not supporting libgfortran.so, at least on aarch64.  You can see the error at
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/jobs/87258888:

===============
Comparing ABIs…
===============
master/files/lib/aarch64-linux-gnu/libgfortran.so
=================================================

in die_pretty_print_type at: abg-dwarf-reader.cc:10955: execution should not
have reached this point!


Basically, this means that libabigail needs to understand Fortran binaries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/23492] Support analysing libgfortran.so
  2018-01-01  0:00 [Bug default/23492] New: Support analysing libgfortran.so dodji at redhat dot com
  2018-01-01  0:00 ` [Bug default/23492] " bochecha at daitauha dot fr
@ 2018-01-01  0:00 ` bochecha at daitauha dot fr
  2018-01-01  0:00 ` dodji at redhat dot com
  2018-01-01  0:00 ` bochecha at daitauha dot fr
  3 siblings, 0 replies; 5+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=23492

--- Comment #2 from Mathieu Bridon <bochecha at daitauha dot fr> ---
Dodji said on IRC the debuginfos are needed as well.

You can get them with:

  flatpak install --user freedesktop-sdk
org.freedesktop.Sdk.Debug/aarch64/unstable

The files will be located in
~/.local/share/flatpak/runtime/org.freedesktop.Sdk.Debug/aarch64/unstable/active/files/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/23492] Support analysing libgfortran.so
  2018-01-01  0:00 [Bug default/23492] New: Support analysing libgfortran.so dodji at redhat dot com
@ 2018-01-01  0:00 ` bochecha at daitauha dot fr
  2018-01-01  0:00 ` bochecha at daitauha dot fr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=23492

Mathieu Bridon <bochecha at daitauha dot fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bochecha at daitauha dot fr

--- Comment #1 from Mathieu Bridon <bochecha at daitauha dot fr> ---
Here's how you can get the offending file:

1. install flatpak
2. add the remote:

  flatpak remote-add --user freedesktop-sdk
https://cache.sdk.freedesktop.org/freedesktop-sdk.flatpakrepo

3. pull the Aarch64 sdk:

  flatpak install --user freedesktop-sdk org.freedesktop.Sdk/aarch64/unstable


At this point, you can reproduce the problem:

  $ abidiff \
     
~/.local/share/flatpak/runtime/org.freedesktop.Sdk/aarch64/unstable/active/files/lib/aarch64-linux-gnu/libgfortran.so
\
     
~/.local/share/flatpak/runtime/org.freedesktop.Sdk/aarch64/unstable/active/files/lib/aarch64-linux-gnu/libgfortran.so
  in die_pretty_print_type at: abg-dwarf-reader.cc:10916: execution should not
have reached this point!
  Aborted (core dumped)

(yes, comparing the file to itself, why not :P )

(in fact, at this point you have the whole Aarch64 Sdk in
~/.local/share/flatpak/runtime/org.freedesktop.Sdk/aarch64/unstable/active/files
so you can even try the rest of the libraries in there if you want :) )

You can run the above on an x86_64 machine, you shouldn't need to have an
Aarch64 one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/23492] Support analysing libgfortran.so
  2018-01-01  0:00 [Bug default/23492] New: Support analysing libgfortran.so dodji at redhat dot com
                   ` (2 preceding siblings ...)
  2018-01-01  0:00 ` dodji at redhat dot com
@ 2018-01-01  0:00 ` bochecha at daitauha dot fr
  3 siblings, 0 replies; 5+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=23492

--- Comment #3 from Mathieu Bridon <bochecha at daitauha dot fr> ---
Confirming it fails on all architectures, not just x86_64.

The reason it didn't fail on other arches is that I wasn't telling abidiff to
look at the debuginfo. Now that I do, it fails as well.

It was failing on Aarch64 though, because for some reason libgfortran.so is not
stripped in our Sdk on Aarch64. :-/

---

tl;dr: Now that I'm using abidiff correctly, it fails the exact same way on
libgfortran.so on all architectures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug default/23492] Support analysing libgfortran.so
  2018-01-01  0:00 [Bug default/23492] New: Support analysing libgfortran.so dodji at redhat dot com
  2018-01-01  0:00 ` [Bug default/23492] " bochecha at daitauha dot fr
  2018-01-01  0:00 ` bochecha at daitauha dot fr
@ 2018-01-01  0:00 ` dodji at redhat dot com
  2018-01-01  0:00 ` bochecha at daitauha dot fr
  3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2018-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=23492

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from dodji at redhat dot com ---
This should be now fixed with the commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=2c6ecfad6fe61c02ef78db97d1b96039c0892fa0
in the master branch of the upstream repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-11-29 14:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-01  0:00 [Bug default/23492] New: Support analysing libgfortran.so dodji at redhat dot com
2018-01-01  0:00 ` [Bug default/23492] " bochecha at daitauha dot fr
2018-01-01  0:00 ` bochecha at daitauha dot fr
2018-01-01  0:00 ` dodji at redhat dot com
2018-01-01  0:00 ` bochecha at daitauha dot fr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).