* [Bug default/23629] New: Libabigail thinks GLib broke ABI
@ 2018-01-01 0:00 bochecha at daitauha dot fr
2018-01-01 0:00 ` Dodji Seketeli
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23629
Bug ID: 23629
Summary: Libabigail thinks GLib broke ABI
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: bochecha at daitauha dot fr
CC: libabigail at sourceware dot org
Target Milestone: ---
Over at the Freedesktop-Sdk project, we're using abidiff to check for ABI
breaks of our whole SDK.
Updating GLib from 2.56. to 2.58, abidiff reports the following:
Functions changes summary: 0 Removed, 1 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
1 function with some indirect sub-type change:
[C]'function void g_clear_object(volatile GObject**)' at gobject.c:3381:1
has some indirect sub-type changes:
parameter 1 of type 'volatile GObject**' changed:
in pointed to type 'volatile GObject*':
in pointed to type 'volatile GObject' at gobject.h:187:1:
entity changed from 'volatile GObject' to 'typedef GObject' at
gobject.h:187:1
type size hasn't changed
This was a deliberate change in GLib:
https://gitlab.gnome.org/GNOME/glib/commit/2aacef39b1cfe4cc5eade704db05ffe1516be22e
Could this be a bug in libabigail, that this isn't considered a harmless
change?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug default/23629] New: Libabigail thinks GLib broke ABI
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
@ 2018-01-01 0:00 ` Dodji Seketeli
2018-01-01 0:00 ` [Bug default/23629] " dodji at redhat dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Dodji Seketeli @ 2018-01-01 0:00 UTC (permalink / raw)
To: bochecha at daitauha dot fr; +Cc: libabigail
"bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org> a
écrit:
> entity changed from 'volatile GObject' to 'typedef GObject' at
> gobject.h:187:1
> type size hasn't changed
[...]
> Could this be a bug in libabigail, that this isn't considered a harmless
> change?
Yes, it is. I think we should flag this change as harmless.
Thanks for pointing this out.
--
Dodji
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug default/23629] Libabigail thinks GLib broke ABI
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
2018-01-01 0:00 ` Dodji Seketeli
@ 2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` dodji at redhat dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: dodji at redhat dot com @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23629
--- Comment #2 from dodji at redhat dot com ---
> Yes, it is. I think we should flag this change as harmless.
Actually, it seems like libabigail 1.4 actually flags this as harmless.
But then it looks like I forgot to update the libabigail package in
Fedora 28. The update should reach that distro soon, i.e:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0f1a9b9137.
Sorry for the inconvenience.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug default/23629] Libabigail thinks GLib broke ABI
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
2018-01-01 0:00 ` Dodji Seketeli
2018-01-01 0:00 ` [Bug default/23629] " dodji at redhat dot com
@ 2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` dodji at seketeli dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: dodji at redhat dot com @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23629
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2018-09-17
Ever confirmed|0 |1
--- Comment #1 from dodji at seketeli dot org ---
"bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org> a
écrit:
> entity changed from 'volatile GObject' to 'typedef GObject' at
> gobject.h:187:1
> type size hasn't changed
[...]
> Could this be a bug in libabigail, that this isn't considered a harmless
> change?
Yes, it is. I think we should flag this change as harmless.
Thanks for pointing this out.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug default/23629] Libabigail thinks GLib broke ABI
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
` (2 preceding siblings ...)
2018-01-01 0:00 ` dodji at redhat dot com
@ 2018-01-01 0:00 ` dodji at seketeli dot org
2018-01-01 0:00 ` bochecha at daitauha dot fr
2020-11-10 10:52 ` maennich at android dot com
5 siblings, 0 replies; 7+ messages in thread
From: dodji at seketeli dot org @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23629
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2018-09-17
Ever confirmed|0 |1
--- Comment #1 from dodji at seketeli dot org ---
"bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org> a
écrit:
> entity changed from 'volatile GObject' to 'typedef GObject' at
> gobject.h:187:1
> type size hasn't changed
[...]
> Could this be a bug in libabigail, that this isn't considered a harmless
> change?
Yes, it is. I think we should flag this change as harmless.
Thanks for pointing this out.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug default/23629] Libabigail thinks GLib broke ABI
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
` (3 preceding siblings ...)
2018-01-01 0:00 ` dodji at seketeli dot org
@ 2018-01-01 0:00 ` bochecha at daitauha dot fr
2020-11-10 10:52 ` maennich at android dot com
5 siblings, 0 replies; 7+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23629
--- Comment #3 from Mathieu Bridon <bochecha at daitauha dot fr> ---
I can confirm this is fixed by libabigail 1.4, which marks this as a harmless
change automatically.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug default/23629] Libabigail thinks GLib broke ABI
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
` (4 preceding siblings ...)
2018-01-01 0:00 ` bochecha at daitauha dot fr
@ 2020-11-10 10:52 ` maennich at android dot com
5 siblings, 0 replies; 7+ messages in thread
From: maennich at android dot com @ 2020-11-10 10:52 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23629
Matthias Maennich <maennich at android dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |maennich at android dot com
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Matthias Maennich <maennich at android dot com> ---
Resolved with 1.4 or later.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-10 10:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-01 0:00 [Bug default/23629] New: Libabigail thinks GLib broke ABI bochecha at daitauha dot fr
2018-01-01 0:00 ` Dodji Seketeli
2018-01-01 0:00 ` [Bug default/23629] " dodji at redhat dot com
2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` dodji at seketeli dot org
2018-01-01 0:00 ` bochecha at daitauha dot fr
2020-11-10 10:52 ` maennich at android dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).