public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/23696] New: abidiff --drop-private-types doesn't drop a few private things
Date: Mon, 01 Jan 2018 00:00:00 -0000	[thread overview]
Message-ID: <bug-23696-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=23696

            Bug ID: 23696
           Summary: abidiff --drop-private-types doesn't drop a few
                    private things
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: bochecha at daitauha dot fr
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Over at Freedesktop SDK, we're currently building file from its release
tarball.

We wanted to move to building it from Git, which this merge request does (among
other things):
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/544

When we do that, the Autotools files get regenerated with newer versions of
autoconf/automake than what the upstream developer had used when they made
their tarball.

As a result, some symbols (functions and variables) get marked as hidden and
disappear from the ABI:
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/544#note_103183484
(see the rest of the discussion on that page for more details)

abidiff reports those removed functions and variables.

However, upon closer inspection, none of those are in public, installed
headers.

file only installs one header: magic.h

Shouldn't abidiff have ignored those removals, since we use
--drop-private-types?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2018-09-20 20:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01  0:00 bochecha at daitauha dot fr [this message]
2018-01-01  0:00 ` [Bug default/23696] " bochecha at daitauha dot fr
2018-01-01  0:00 ` bochecha at daitauha dot fr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-23696-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).