* [Bug default/23696] abidiff --drop-private-types doesn't drop a few private things
2018-01-01 0:00 [Bug default/23696] New: abidiff --drop-private-types doesn't drop a few private things bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23696] " bochecha at daitauha dot fr
@ 2018-01-01 0:00 ` bochecha at daitauha dot fr
1 sibling, 0 replies; 3+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23696
Mathieu Bridon <bochecha at daitauha dot fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Mathieu Bridon <bochecha at daitauha dot fr> ---
Dodji said on IRC this is expected.
--drop-private-types is only for types, not for functions and variables.
Unfortunately, at this time libabigail can't really drop private functions and
variables, simply because it can't identify them reliably from headers.
Closing.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug default/23696] New: abidiff --drop-private-types doesn't drop a few private things
@ 2018-01-01 0:00 bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23696] " bochecha at daitauha dot fr
2018-01-01 0:00 ` bochecha at daitauha dot fr
0 siblings, 2 replies; 3+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23696
Bug ID: 23696
Summary: abidiff --drop-private-types doesn't drop a few
private things
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: bochecha at daitauha dot fr
CC: libabigail at sourceware dot org
Target Milestone: ---
Over at Freedesktop SDK, we're currently building file from its release
tarball.
We wanted to move to building it from Git, which this merge request does (among
other things):
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/544
When we do that, the Autotools files get regenerated with newer versions of
autoconf/automake than what the upstream developer had used when they made
their tarball.
As a result, some symbols (functions and variables) get marked as hidden and
disappear from the ABI:
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/544#note_103183484
(see the rest of the discussion on that page for more details)
abidiff reports those removed functions and variables.
However, upon closer inspection, none of those are in public, installed
headers.
file only installs one header: magic.h
Shouldn't abidiff have ignored those removals, since we use
--drop-private-types?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug default/23696] abidiff --drop-private-types doesn't drop a few private things
2018-01-01 0:00 [Bug default/23696] New: abidiff --drop-private-types doesn't drop a few private things bochecha at daitauha dot fr
@ 2018-01-01 0:00 ` bochecha at daitauha dot fr
2018-01-01 0:00 ` bochecha at daitauha dot fr
1 sibling, 0 replies; 3+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23696
Mathieu Bridon <bochecha at daitauha dot fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INVALID
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-21 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-01 0:00 [Bug default/23696] New: abidiff --drop-private-types doesn't drop a few private things bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23696] " bochecha at daitauha dot fr
2018-01-01 0:00 ` bochecha at daitauha dot fr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).