From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libabigail-return-1244-listarch-libabigail=sourceware.org@sourceware.org>
Received: (qmail 30358 invoked by alias); 20 Sep 2018 20:17:09 -0000
Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:libabigail@sourceware.org>
List-Help: <mailto:libabigail-help@sourceware.org>
List-Id: <libabigail.sourceware.org>
List-Subscribe: <mailto:libabigail-subscribe@sourceware.org>
Sender: libabigail-owner@sourceware.org
Received: (qmail 30292 invoked by uid 48); 20 Sep 2018 20:17:05 -0000
From: "bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/23696] New: abidiff --drop-private-types doesn't drop a few private things
Date: Mon, 01 Jan 2018 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bochecha at daitauha dot fr
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-23696-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2018-q3/txt/msg00022.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D23696

            Bug ID: 23696
           Summary: abidiff --drop-private-types doesn't drop a few
                    private things
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: bochecha at daitauha dot fr
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Over at Freedesktop SDK, we're currently building file from its release
tarball.

We wanted to move to building it from Git, which this merge request does (a=
mong
other things):
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/544

When we do that, the Autotools files get regenerated with newer versions of
autoconf/automake than what the upstream developer had used when they made
their tarball.

As a result, some symbols (functions and variables) get marked as hidden and
disappear from the ABI:
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/544#note_=
103183484
(see the rest of the discussion on that page for more details)

abidiff reports those removed functions and variables.

However, upon closer inspection, none of those are in public, installed
headers.

file only installs one header: magic.h

Shouldn't abidiff have ignored those removals, since we use
--drop-private-types?

--=20
You are receiving this mail because:
You are on the CC list for the bug.