* [Bug default/23708] New: An ABI change which could be marked as harmless
@ 2018-01-01 0:00 bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23708] void* to pointer change should be categorized " dodji at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: bochecha at daitauha dot fr @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23708
Bug ID: 23708
Summary: An ABI change which could be marked as harmless
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: bochecha at daitauha dot fr
CC: libabigail at sourceware dot org
Target Milestone: ---
Created attachment 11272
--> https://sourceware.org/bugzilla/attachment.cgi?id=11272&action=edit
A tarball containing the libraries, debuginfos and headers, to reproduce the
commands in the bug description
Attached is a tarball which contains two trees of built/installed libepoxy.
The only difference between the two is that libepoxy-before was built with the
Autotools while libepoxy-after was built with Meson.
Due to an upstream bug in their Autotools build system, this causes an ABI
break: https://github.com/anholt/libepoxy/issues/188
However, Dodji is saying this might actually be a harmless ABI change, which
libabigail could learn to categorize better.
$ tar xf ../libepoxy-reproducer.tar.xz
abidiff --no-added-syms --drop-private-types --headers-dir1
libepoxy-before/usr/include --headers-dir2 libepoxy-after/usr/include
--debug-info-dir1 libepoxy-before/usr/lib/debug --debug-info-dir2
libepoxy-after/usr/lib/debug
libepoxy-before/usr/lib/x86_64-linux-gnu/libepoxy.so.0.0.0
libepoxy-after/usr/lib/x86_64-linux-gnu/libepoxy.so.0.0.0
Functions changes summary: 0 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 2 Changed (5 filtered out), 0 Added
variables
2 Changed variables:
[C]'typedef EGLDisplay (typedef EGLNativeDisplayType)* epoxy_eglGetDisplay'
was changed at egl_generated.h:991:1:
type of variable changed:
in pointed to type 'function type typedef EGLDisplay (typedef
EGLNativeDisplayType)':
parameter 1 of type 'typedef EGLNativeDisplayType' changed:
underlying type 'void*' changed:
in pointed to type 'void' at Xlib.h:487:1:
entity changed from 'void' to 'typedef Display' at Xlib.h:487:1
type size hasn't changed
[C]'typedef EGLBoolean (typedef EGLDisplay, EGLNativeDisplayType*)*
epoxy_eglQueryNativeDisplayNV' was changed at egl_generated.h:1063:1:
type of variable changed:
in pointed to type 'function type typedef EGLBoolean (typedef EGLDisplay,
EGLNativeDisplayType*)':
parameter 2 of type 'EGLNativeDisplayType*' changed:
pointed to type 'typedef EGLNativeDisplayType' changed at
eglplatform.h:117:1, as reported earlier
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/23708] void* to pointer change should be categorized as harmless
2018-01-01 0:00 [Bug default/23708] New: An ABI change which could be marked as harmless bochecha at daitauha dot fr
@ 2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` [Bug default/23708] An ABI change which could be marked " dodji at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dodji at redhat dot com @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23708
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from dodji at redhat dot com ---
This should now be fixed by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=caa100603efcedc748edbd4bdee638827ddcae4b
in the master git branch.
Thank you for filing this issue!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/23708] An ABI change which could be marked as harmless
2018-01-01 0:00 [Bug default/23708] New: An ABI change which could be marked as harmless bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23708] void* to pointer change should be categorized " dodji at redhat dot com
2018-01-01 0:00 ` dodji at redhat dot com
@ 2018-01-01 0:00 ` dodji at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dodji at redhat dot com @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23708
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2018-10-02
Ever confirmed|0 |1
--- Comment #1 from dodji at redhat dot com ---
I agree. Changing a void* pointer into another pointer of the same size should
not be considered as a harmful change.
So I am going to teach the diff classifier to categorize that change as
harmless.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/23708] void* to pointer change should be categorized as harmless
2018-01-01 0:00 [Bug default/23708] New: An ABI change which could be marked as harmless bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23708] void* to pointer change should be categorized " dodji at redhat dot com
@ 2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` [Bug default/23708] An ABI change which could be marked " dodji at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dodji at redhat dot com @ 2018-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=23708
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|An ABI change which could |void* to pointer change
|be marked as harmless |should be categorized as
| |harmless
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-03 10:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-01 0:00 [Bug default/23708] New: An ABI change which could be marked as harmless bochecha at daitauha dot fr
2018-01-01 0:00 ` [Bug default/23708] void* to pointer change should be categorized " dodji at redhat dot com
2018-01-01 0:00 ` dodji at redhat dot com
2018-01-01 0:00 ` [Bug default/23708] An ABI change which could be marked " dodji at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).