[Bug default/24257] abidiff: Spurious data member insertion errors on aarch64 and arm.

[Bug default/24257] abidiff: Spurious data member insertion errors on aarch64 and arm.

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24257

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2019-03-21
     Ever confirmed|0                           |1

--- Comment #2 from dodji at redhat dot com ---
I am looking at this issue.  It's definitely a libabigail bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/24257] New: abidiff: Spurious data member insertion errors on aarch64 and arm.

[valentin.david at codethink dot co.uk]

https://sourceware.org/bugzilla/show_bug.cgi?id=24257

            Bug ID: 24257
           Summary: abidiff: Spurious data member insertion errors on
                    aarch64 and arm.
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: valentin.david at codethink dot co.uk
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 11637
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11637&action=edit
The files causing the spurious error

abidiff: 1.5.0

Error message:
1 function with some indirect sub-type change:

  [C]'function int __addmntent(FILE*, const mntent*)' at mntent_r.c:250:1 has
some indirect sub-type changes:
    Please note that the exported symbol of this function is
addmntent@@GLIBC_2.17
    parameter 1 of type 'FILE*' has sub-type changes:
      in pointed to type 'typedef FILE' at FILE.h:7:1:
        underlying type 'struct _IO_FILE' at libio.h:245:1 changed:
          type size hasn't changed
          1 data member insertion:
            '_IO_lock_t* _IO_FILE::_lock', at offset 1088 (in bits) at
libio.h:284:1

Link to logs:
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/jobs/165187295

I checked the debuginfo of both files, and there is no difference on struct
_IO_FILE, and member _lock.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/24257] abidiff: Spurious data member insertion errors on aarch64 and arm.

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24257

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from dodji at redhat dot com ---
This issue should be fixed by commits
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=fc02416b2847c73909391c062f9e1522aa2c3864
and
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=0036d0448ed45af7de7f0f461241040f7d0974f4
in the master branch of the git repository.

It should be available in the upcoming 1.6 version of Libabigail.

Thank you for taking the time to file this issue and sorry for the
inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/24257] abidiff: Spurious data member insertion errors on aarch64 and arm.

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24257

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
I see this in glibc testing also but there it's a member insertion.

comparing old vs new version of lib64/libc-2.17.so, in package glibc of ABI
compatibility level 1 on aarch64 revealed ABI differences:
Functions changes summary: 0 Removed, 1 Changed (9 filtered out), 0 Added (2
filtered out) functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C]'function void __argp_error(const argp_state*, const char*, ...)' at
argp-help.c:1753:1 has some indirect sub-type changes:
    Please note that the exported symbol of this function is
argp_error@@GLIBC_2.17
    parameter 1 of type 'const argp_state*' has sub-type changes:
      in pointed to type 'const argp_state':
        in unqualified underlying type 'struct argp_state' at argp.h:310:1:
          type size hasn't changed
          1 data member changes (1 filtered):
           type of 'FILE* argp_state::err_stream' changed:
             in pointed to type 'typedef FILE' at stdio.h:48:1:
               underlying type 'struct _IO_FILE' at libio.h:246:1 changed:
                 type size hasn't changed
                 1 data member deletion:
                   '_IO_lock_t* _IO_FILE::_lock', at offset 1088 (in bits) at
libio.h:285:1

-- 
You are receiving this mail because:
You are on the CC list for the bug.