* [Bug default/24552] New: abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group
@ 2019-01-01 0:00 maennich at google dot com
2019-01-01 0:00 ` [Bug default/24552] " maennich at google dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: maennich at google dot com @ 2019-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=24552
Bug ID: 24552
Summary: abidiff: different comparison rules for abi-corpus vs
abi-corpus within an abi-corpus group
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: maennich at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
Created attachment 11774
--> https://sourceware.org/bugzilla/attachment.cgi?id=11774&action=edit
Minimal xml representations to reproduce the issue
abidiff seems to apply different rules for abi-corpus and abi-corpus as part of
an abi-corpus-group.
I stumbled upon that one when comparing xml representation of vmlinux once with
abidw path1/to/vmlinux --out-file abi1_file.out
abidw path2/to/vmlinux --out-file abi2_file.out
abidiff abi1_file.out abi2_file.out
and once with
abidw --linux-tree path1/to/ --out-file abi1_tree.out
abidw --linux-tree path2/to/ --out-file abi2_tree.out
abidiff abi1_tree.out abi2_tree.out
In the latter case a difference was reported. The diff between abi1_file.out
and abi1_tree.out seems to be that vmlinux as part of the tree is nested into a
abi-corpus-group.
I will attach reduced versions of the xml files to easily reproduce the issue
with
abidiff success?.out
vs
abidiff fail?.out
(Why there is the 'elf-symbol-id' attribute missing even though there is a
elf-function-symbol entry for it, is probably another bug to be filed.)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug default/24552] abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group
2019-01-01 0:00 [Bug default/24552] New: abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group maennich at google dot com
@ 2019-01-01 0:00 ` maennich at google dot com
2019-01-01 0:00 ` dodji at redhat dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: maennich at google dot com @ 2019-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=24552
--- Comment #1 from Matthias Maennich <maennich at google dot com> ---
Forgot to mention: the output in the fail case is
Functions changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out)
function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
Function symbols changes summary: 1 Removed, 0 Added function symbol not
referenced by debug info
Variable symbols changes summary: 0 Removed, 0 Added variable symbol not
referenced by debug info
1 Removed function symbol not referenced by debug info:
func
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug default/24552] abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group
2019-01-01 0:00 [Bug default/24552] New: abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group maennich at google dot com
2019-01-01 0:00 ` [Bug default/24552] " maennich at google dot com
2019-01-01 0:00 ` dodji at redhat dot com
@ 2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2019-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=24552
--- Comment #2 from dodji at redhat dot com ---
This should now be fixed in master by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=f754d8111656b2ebb480952035ecd0746d3c2287.
That fix should be available in the 1.7 version of libabigail.
Thank for taking the time to file this problem and sorry for the inconvenience!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug default/24552] abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group
2019-01-01 0:00 [Bug default/24552] New: abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group maennich at google dot com
2019-01-01 0:00 ` [Bug default/24552] " maennich at google dot com
@ 2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2019-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=24552
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2019-05-15
Ever confirmed|0 |1
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug default/24552] abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group
2019-01-01 0:00 [Bug default/24552] New: abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group maennich at google dot com
` (2 preceding siblings ...)
2019-01-01 0:00 ` dodji at redhat dot com
@ 2019-01-01 0:00 ` dodji at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: dodji at redhat dot com @ 2019-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=24552
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from dodji at redhat dot com ---
Closing.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-16 16:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01 0:00 [Bug default/24552] New: abidiff: different comparison rules for abi-corpus vs abi-corpus within an abi-corpus group maennich at google dot com
2019-01-01 0:00 ` [Bug default/24552] " maennich at google dot com
2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).