From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/24731] abidiff: Incorrect ABI difference reporting for union changing order of members
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <bug-24731-9487-o3blkIzcsN@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-24731-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=24731
--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Further supporting that supposition that there are two bugs the corpus looks
correct:
$ abidw test1.o | sed -e 's/test1/test2/' > test1.dw # so the filenames don't
add noise
$ abidw test2.o > test2.dw
$ diff -u test1.dw test2.dw
--- test1.dw 2019-06-25 13:38:41.510614347 -0700
+++ test2.dw 2019-06-25 13:36:17.003307489 -0700
@@ -9,15 +9,15 @@
<var-decl name='a' type-id='type-id-3' visibility='default'
filepath='/home/ben/Work/libabigail/test/test2.c' line='1' column='1'/>
</data-member>
<data-member access='private'>
- <var-decl name='c' type-id='type-id-4' visibility='default'
filepath='/home/ben/Work/libabigail/test/test2.c' line='1' column='1'/>
+ <var-decl name='s' type-id='type-id-4' visibility='default'
filepath='/home/ben/Work/libabigail/test/test2.c' line='1' column='1'/>
</data-member>
<data-member access='private'>
- <var-decl name='s' type-id='type-id-5' visibility='default'
filepath='/home/ben/Work/libabigail/test/test2.c' line='1' column='1'/>
+ <var-decl name='c' type-id='type-id-5' visibility='default'
filepath='/home/ben/Work/libabigail/test/test2.c' line='1' column='1'/>
</data-member>
</union-decl>
<type-decl name='int' size-in-bits='32' id='type-id-3'/>
- <type-decl name='char' size-in-bits='8' id='type-id-4'/>
- <type-decl name='short int' size-in-bits='16' id='type-id-5'/>
+ <type-decl name='short int' size-in-bits='16' id='type-id-4'/>
+ <type-decl name='char' size-in-bits='8' id='type-id-5'/>
<function-decl name='test_func' mangled-name='test_func'
filepath='/home/ben/Work/libabigail/test/test2.c' line='3' column='1'
visibility='default' binding='global' size-in-bits='64'
elf-symbol-id='test_func'>
<parameter type-id='type-id-2' name='var'
filepath='/home/ben/Work/libabigail/test/test2.c' line='3' column='1'/>
<return type-id='type-id-1'/>
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2019-06-25 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [Bug default/24731] New: " maennich at google dot com
2019-01-01 0:00 ` [Bug default/24731] " dodji at redhat dot com
2019-01-01 0:00 ` woodard at redhat dot com [this message]
2019-01-01 0:00 ` maennich at google dot com
2019-01-01 0:00 ` woodard at redhat dot com
2019-01-01 0:00 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-24731-9487-o3blkIzcsN@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).