public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "simark at simark dot ca" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/25058] abigail does not handle subprogram DIEs with DW_AT_ranges instead of DW_AT_low_pc
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <bug-25058-9487-wzMwA8VMEY@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25058-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25058

--- Comment #4 from Simon Marchi <simark at simark dot ca> ---
(In reply to Mark Wielaard from comment #3)
> Instead of checking for the Dw_AT_low_pc attribute value, libabigail should
> probably use libdw dwarf_ranges () which works for either low_pc/high_pc
> pairs (single range) or DW_AT_ranges/rnglists.

So, libabigail uses the function's low pc to try to find the ELF symbol
corresponding to the function DIE it is currently processing.  If it uses the
ranges, which address should it use to look up the ELF symbol?  Typically, one
range will correspond to the ".cold" version of the symbol and one range will
correspond to the symbol we are looking for.

I suppose it could try to look up an ELF symbol using the "low pc" of each
range, until it finds one whose name corresponds to the DW_AT_linkage_name of
the function DIE (if the DIE has that attribute).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2019-10-02 21:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 [Bug default/25058] New: abigail does not recognize simark at simark dot ca
2019-01-01  0:00 ` [Bug default/25058] abigail does not handle subprogram DIEs with DW_AT_ranges instead of DW_AT_low_pc mark at klomp dot org
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00 ` dodji at seketeli dot org
2019-01-01  0:00 ` mark at klomp dot org
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00 ` simark at simark dot ca [this message]
2019-01-01  0:00   ` Dodji Seketeli
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00   ` Dodji Seketeli
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00 ` dodji at seketeli dot org
2019-01-01  0:00 ` dodji at redhat dot com
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00 ` simark at simark dot ca
2019-01-01  0:00 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25058-9487-wzMwA8VMEY@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).