public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "jwakely.gcc at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/25753] New: Add note to add/removed functions that are in comdat sections
Date: Tue, 31 Mar 2020 12:17:44 +0000	[thread overview]
Message-ID: <bug-25753-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=25753

            Bug ID: 25753
           Summary: Add note to add/removed functions that are in comdat
                    sections
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: jwakely.gcc at gmail dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

For C++ libraries a small code change or a slightly different compiler version
can alter inlining decisions, causing previously emitted functions to be
inlined and disappear from the generated code, causing abigail to report
removed functions. The opposite can also happen where previously inlined
functions start to be emitted, and abigail reports added functions.

If an added/removed symbol is in a comdat section, it probably means it's
inline and not actually a part of the library's ABI. The fact a symbol is in
comdat is already in the metadata, so it would be useful to add a note about
comdat when showing added/removed functions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2020-03-31 12:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 12:17 jwakely.gcc at gmail dot com [this message]
2021-01-19 17:25 ` [Bug default/25753] " dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25753-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).