[Bug default/25986] New: Wrong name of function type used in change report

[Bug default/25986] New: Wrong name of function type used in change report

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25986

            Bug ID: 25986
           Summary: Wrong name of function type used in change report
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 12533
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12533&action=edit
Tarball containing two *.abi files and their source file

When I abidiff the two *.abi files from the attached tarball, I get:

$ abidiff test-fun-param-v0.abi test-fun-param-v1.abi
Functions changes summary: 0 Removed, 1 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'function void reg(ops*)' at test-fun-param-v1.c:7:1 has some indirect
sub-type changes:
    parameter 1 of type 'ops*' has sub-type changes:
      in pointed to type 'struct ops' at test-fun-param-v1.c:1:1:
        type size hasn't changed
        1 data member change:
          type of 'void ()* ops::bind_class' changed:
            in pointed to type 'function type void (void*, unsigned int,
unsigned long int)':
              parameter 4 of type 'void*' was added
              parameter 5 of type 'unsigned long int' was added

$ 

Note how the type part of "type of 'void ()* ops::bind_class'" is wrong.  We
should have a property function type name, rather than 'void ()'.

I am filling this report based on an email received on the mailing list at
https://sourceware.org/pipermail/libabigail/2020q2/002166.html.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25986] Wrong name of function type used in change report

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25986

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from dodji at redhat dot com ---
I have proposed a patch for this issue at
https://sourceware.org/pipermail/libabigail/2020q2/002233.html.

Let's see what the discussion yields.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25986] Wrong name of function type used in change report

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25986

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
The patch was applied to master at
https://sourceware.org/git/?p=libabigail.git;a=commit;h=e2341a939c4058ba64d44375b13be302dac4e133.

It was tested as reported by
https://sourceware.org/pipermail/libabigail/2020q2/002237.html.

-- 
You are receiving this mail because:
You are on the CC list for the bug.