From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id C874C3840C1A; Tue, 19 May 2020 17:43:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C874C3840C1A From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/25998] Support incomplete enum types Date: Tue, 19 May 2020 17:43:53 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cf_reconfirmed_on bug_status everconfirmed Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 17:43:53 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D25998 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Last reconfirmed| |2020-05-19 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from dodji at redhat dot com --- Hello, Thank you for filling this enhancement request and for working on its underlying feature. I agree with you that the incomplete enum support is needed and I am glad t= hat you started working on it. I want to help get it in, so I am looking at it. As for the way to go, I tend to not be a fan of early optimization. So rea= lly, at first, I wouldn't spend to much time (and I'd rather not spent too much review time) on trying to remove duplicated code etc. I'd rather want to have the feature in and make it work solidly first. Of course, if the design is elegant enough to integrate with the code base in a manner that avoids duplication, then fine. But I don't think we should go = out of our way to try and squeeze all the juice out of avoiding duplication. Incidentally, I have posted a comment on the WIP types patches at https://sourceware.org/pipermail/libabigail/2020q2/002262.html. I'll be looking at the C++ enum type specification again, as I don't have t= he details in mind at the moment. Thanks again! --=20 You are receiving this mail because: You are on the CC list for the bug.=