From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 4101B3850403; Tue, 26 Jan 2021 13:10:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4101B3850403 From: "gprocida+abigail at google dot com" To: libabigail@sourceware.org Subject: [Bug default/26013] abidiff: collapse subsequent data member offset changes Date: Tue, 26 Jan 2021 13:10:53 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: gprocida+abigail at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 13:10:53 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26013 Giuliano Procida changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gprocida+abigail at google= dot com --- Comment #1 from Giuliano Procida -= -- Hi Dodji. This is to give you an update where we are with this. I decided that openin= g up and operating on abidiff to achieve the stated aim would be quite (and too) intrusive, particularly given the relative ease with which this can be done= in post-processing. We've implemented a post-processor which generates output like the followin= g. ... 8 ('foo' .. 'bar') offsets changed (by +256 bits) ... Only consecutive runs where the members have identical offset changes - and only offset changes - are summarised like this. In abidiff, the trickiest bit would be determining that there were no other changes. This can only be done with a holistic view of either the diff outp= ut (which might mean pushing functionality into the ostream object) or perhaps member diffs (but that would require adding a lot of functionality and prob= ably splitting the change categories SIZE and OFFSET as I proposed long ago). The idea to do something with ostream using for reporting is not terrible. = For example, much of the indentation logic could be centralised there; multiple post-processing filters could be added. But... we actually find it useful to have the full unexpurgated report and = use post-processing to yield a shorter report that users look at by default. We only have to run abidiff once. That was a bit of a longer update than I intended. The post-processing code= is here, if you're interested. It includes a couple of other filters. https://android.googlesource.com/kernel/build/+/refs/heads/master/abi/abito= ol.py Regards. --=20 You are receiving this mail because: You are on the CC list for the bug.=