From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 21D77388E81A; Thu, 17 Sep 2020 14:17:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21D77388E81A From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/26135] Wrong linkage name causes anonymous classes miscomparison Date: Thu, 17 Sep 2020 14:17:07 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 14:17:07 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26135 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #6 from dodji at redhat dot com --- (In reply to Giuliano Procida from comment #4) > Hi Dodji. >=20 > I was looking at type ids in another context and noticed the following. >=20 > $ git grep -c " id=3D'type-id-24'" > 346e88dd~1:tests/data/test-read-dwarf/PR22122-libftdc.so.abi > 346e88dd~1:tests/data/test-read-dwarf/PR22122-libftdc.so.abi:138 > $ git grep -c " id=3D'type-id-24'" > 346e88dd:tests/data/test-read-dwarf/PR22122-libftdc.so.abi > 346e88dd:tests/data/test-read-dwarf/PR22122-libftdc.so.abi:708 >=20 > While 138 declaration-only anonymous types sharing the same id (and so I > imagine the same canonical type) looks suspicious, 708 doing so is > presumably worse. I looked into this and it appears that the type with the ID "type-id-24" is= an anonymous class with no data member, no base classes, and which only conta= ins non-virtual member functions and/or some member type. For classes containing no virtual member functions, only base classes and d= ata member are taken into account for identity. So this seems normal to me. Furthermore, as we've been increasing the likelihood of recognizing two anonymous types as equivalent, I rather find = this particular increase in duplicated ids as positive. > I'm sorry I didn't check the test files more carefully sooner. Nah, I think you've done great spotting this. This could have been a real issue. Incidentally, I have filed an enhancement request to detect pathological ca= ses of duplicated IDs at https://sourceware.org/bugzilla/show_bug.cgi?id=3D2659= 1. Thanks! --=20 You are receiving this mail because: You are on the CC list for the bug.=