From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 5BF793851C2C; Thu, 30 Jul 2020 14:35:12 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5BF793851C2C
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26261] unfinished handling of comparing
 DW_TAG_subroutine_type DIEs in compare_dies
Date: Thu, 30 Jul 2020 14:35:12 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dodji at redhat dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: short_desc
Message-ID: <bug-26261-9487-i1r5Mr41z5@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26261-9487@http.sourceware.org/bugzilla/>
References: <bug-26261-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 14:35:12 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26261

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|compare_dies contains some  |unfinished handling of
                   |useless code                |comparing
                   |                            |DW_TAG_subroutine_type DIEs
                   |                            |in compare_dies

--- Comment #1 from dodji at redhat dot com ---
Yes, you are right.  That denotes some unfinished code there.

The intent was to safely detect when we could get out early and not proceed=
 to
the full potentially slow structural comparison.  So essentially what is
missing there is a "break" statement, I think.

I am coming up with a patch to finish that part of the code.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=