From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B67C93858009; Sat, 20 Mar 2021 10:32:27 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B67C93858009
From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26591] detect pathologically redundant types in abixml
Date: Sat, 20 Mar 2021 10:32:27 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: gprocida+abigail at google dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26591-9487-KnkvEchjME@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26591-9487@http.sourceware.org/bugzilla/>
References: <bug-26591-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Mar 2021 10:32:27 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26591

--- Comment #6 from Giuliano Procida <gprocida+abigail at google dot com> -=
--
One of the worst cases of duplicate type ids being used for different types
(genuinely different it seems, not fragments of each other) is type-id-60 in
tests/data/test-read-dwarf/PR22122-libftdc.so.

This is a snippet of abidw tests/data/test-read-dwarf/PR22122-libftdc.so |
c++filt.

      <class-decl name=3D'__anonymous_struct__' is-anonymous=3D'yes'
visibility=3D'default' is-declaration-only=3D'yes' id=3D'type-id-60'>
        <member-function access=3D'public'>
          <function-decl name=3D'intrusive_ptr'
mangled-name=3D'boost::intrusive_ptr<mongo::SharedBuffer::Holder>::intrusiv=
e_ptr()'
filepath=3D'src/third_party/boost-1.60.0/boost/smart_ptr/intrusive_ptr.hpp'
line=3D'62' column=3D'1' visibility=3D'default' binding=3D'global' size-in-=
bits=3D'64'>
            <parameter type-id=3D'type-id-63' is-artificial=3D'yes'/>
            <return type-id=3D'type-id-26'/>
          </function-decl>
        </member-function>
        <member-function access=3D'public' destructor=3D'yes'>
          <function-decl name=3D'~intrusive_ptr'
mangled-name=3D'boost::intrusive_ptr<mongo::SharedBuffer::Holder>::~intrusi=
ve_ptr()'
filepath=3D'src/third_party/boost-1.60.0/boost/smart_ptr/intrusive_ptr.hpp'
line=3D'95' column=3D'1' visibility=3D'default' binding=3D'global' size-in-=
bits=3D'64'>
            <parameter type-id=3D'type-id-63' is-artificial=3D'yes'/>
            <return type-id=3D'type-id-26'/>
          </function-decl>
        </member-function>
      </class-decl>
      <class-decl name=3D'__anonymous_struct__1' is-anonymous=3D'yes'
visibility=3D'default' is-declaration-only=3D'yes' id=3D'type-id-60'>
        <member-type access=3D'private'>
          <typedef-decl name=3D'rval_reference_type' type-id=3D'type-id-152'
filepath=3D'src/third_party/boost-1.60.0/boost/optional/optional.hpp' line=
=3D'777'
column=3D'1' id=3D'type-id-153'/>
        </member-type>
        <member-function access=3D'public'>
          <function-decl name=3D'optional'
mangled-name=3D'boost::optional<std::vector<mongo::BSONObj,
std::allocator<mongo::BSONObj> > >::optional()'
filepath=3D'src/third_party/boost-1.60.0/boost/optional/optional.hpp' line=
=3D'786'
column=3D'1' visibility=3D'default' binding=3D'global' size-in-bits=3D'64'>
            <parameter type-id=3D'type-id-63' is-artificial=3D'yes'/>
            <return type-id=3D'type-id-26'/>
          </function-decl>
        </member-function>
        <member-function access=3D'public'>
          <function-decl name=3D'optional'
mangled-name=3D'boost::optional<mongo::FTDCBSONUtil::FTDCType>::optional(mo=
ngo::FTDCBSONUtil::FTDCType&&)'
filepath=3D'src/third_party/boost-1.60.0/boost/optional/optional.hpp' line=
=3D'799'
column=3D'1' visibility=3D'default' binding=3D'global' size-in-bits=3D'64'>
            <parameter type-id=3D'type-id-63' is-artificial=3D'yes'/>
            <parameter type-id=3D'type-id-153'/>
            <return type-id=3D'type-id-26'/>
          </function-decl>
        </member-function>
      </class-decl>

Both are anonymous, declaration-only classes but contain member functions t=
hat
clearly belong to named, defined templated types.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=