From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 3F15F3857401; Fri,  8 Jul 2022 11:13:25 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F15F3857401
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26591] detect pathologically redundant types in abixml
Date: Fri, 08 Jul 2022 11:13:24 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: gprocida at google dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26591-9487-ricbjto1wi@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26591-9487@http.sourceware.org/bugzilla/>
References: <bug-26591-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jul 2022 11:13:25 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26591

--- Comment #14 from gprocida at google dot com ---
I made a tiny start on this:

static Dwarf_Die*
check_signature(Dwarf_Die* die, Dwarf_Die* signature_die)
{
  Dwarf_Attribute attr;
  return die && dwarf_attr_integrate(die, DW_AT_signature, &attr)
      && dwarf_formref_die(&attr, signature_die) ? signature_die : die;
}

and then in build_ir_node_from_die:

  Dwarf_Die signature;
  die =3D check_signature(die, &signature);

However, it breaks assumptions about canonical DIEs. Or at least, I get
assertion failures in compute_canonical_die:

    ABG_ASSERT(dwarf_offdie(dwarf_per_die_source(source), die_offset, &die)=
);

--=20
You are receiving this mail because:
You are on the CC list for the bug.=