From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 145143857C45; Wed, 7 Oct 2020 09:33:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 145143857C45 From: "gprocida+abigail at google dot com" To: libabigail@sourceware.org Subject: [Bug default/26646] unexpectedly declaration-only types Date: Wed, 07 Oct 2020 09:33:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida+abigail at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 09:33:22 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26646 --- Comment #3 from Giuliano Procida -= -- I'd recommend doing the following. build/tools/abidw --no-comp-dir-path --no-show-locs --type-id-style hash vmlinux mainline.xml.master cherry-pick the patch https://sourceware.org/pipermail/libabigail/2020q3/002679.html and rebuild build/tools/abidw --no-comp-dir-path --no-show-locs --type-id-style hash vmlinux mainline.xml.ordered Despite the abidw options given, it's a bit much to try to diff these by ha= nd as there are thousands of differences. Analysis shows 168 fewer declaration-only (only) types in the latter XML. *Assuming* both XML files are in some sense valid, abidiff can illustrate o= ther potential problems. It would make sense to open separate Bugzilla issues, if confirmed. Do 4 abidiffs (with / without --harmless, with / without --leaf-changes-onl= y) between mainline.xml.master and mainline.xml.ordered. abidiff - shows lots of stuff being filtered out (hmmm) abidiff --harmless - shows diffs like the following (bug?) type changed from: union {snd_info_entry_text text; const snd_info_entry_ops* op= s;} to: union {snd_info_entry_text text; const snd_info_entry_ops* op= s;} abidiff --leaf-changes-only - shows some type changes filtered out abidiff --leaf-changes-only --harmless - shows there's at least one bug in reporting (perhaps due to the same anonymous union issue?) Lastly, some of these abidiff runs take a long time (up to 7 minutes on a f= ast machine), but that may be expected given the large XML differences. --=20 You are receiving this mail because: You are on the CC list for the bug.=