From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 4A7C63858407; Thu,  3 Mar 2022 13:32:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A7C63858407
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26646] unexpected declaration-only types
Date: Thu, 03 Mar 2022 13:32:46 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida at google dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26646-9487-YEFkFoQRB0@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26646-9487@http.sourceware.org/bugzilla/>
References: <bug-26646-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2022 13:32:46 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26646

--- Comment #34 from gprocida at google dot com ---
Hi.

compare_dies is almost exactly the right shape to be able to drop in the mo=
re
sophisticated cycle-handling logic (a.k.a. SCC finder) and I've posted an R=
FC
patch to show the small changes needed there and also to note that things d=
on't
quite work, as mentioned already.

If had a better idea as to what compute_ and get_canonical_die_offset are
doing, I might be able to fix things myself, but I don't.

However, if you feel this is a separate project for another time, that's fa=
ir
enough.

In particular, I have no expectation that dropping in the SCC finder and
getting compare_dies working with it will do anything other than make the
aggregates-being-compared logic more precise and complete. I don't think it
will address this (declaration-only types) bug report in general.

Regards,
Giuliano.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=