From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 70DBD3858C20; Thu, 10 Feb 2022 18:53:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70DBD3858C20
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26646] unexpected declaration-only types
Date: Thu, 10 Feb 2022 18:53:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida at google dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26646-9487-fUiufdngU8@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26646-9487@http.sourceware.org/bugzilla/>
References: <bug-26646-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Feb 2022 18:53:18 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26646

--- Comment #20 from gprocida at google dot com ---
Hi.

I've tested the latest patch.

It increased the number of fully-defined types for vmlinux3! Unfortunately,
while it also added the same type definition for vmlinux4, our old friend
ip_mc_list became declaration-only. :-(

I still think it is a step in the right direction. Certainly the recursion
limit of 5 aggregates was arbitrary and small unit tests would be unlikely =
to
exercise the code.

In terms of the code...

I think it would be better to store pairs of offsets though it would probab=
ly
be extremely hard to find an example where this would make any difference.

It's safe to recurse a bit too much, so long as there is some termination
guarantee, but potentially unsafe to stop recursion too early which is
theoretically possible if you compare DIEs A and B and deeper in the recurs=
ion
want to compare C and B.

The comparison algorithm I put together tracks pairs of nodes compared as t=
his
corresponds exactly to the design aim of avoiding repeated comparisons.

Giuliano.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=