From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 4A382393BC37; Fri, 20 Nov 2020 15:34:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A382393BC37
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26769] abixml writer misses some member types in the
 output
Date: Fri, 20 Nov 2020 15:34:58 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dodji at redhat dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26769-9487-PIILqVv5fq@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26769-9487@http.sourceware.org/bugzilla/>
References: <bug-26769-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2020 15:34:58 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26769

--- Comment #11 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #2)
> dodji, this needs to be a standard unit test:
>=20
> $ lib=3D/lib64/libabigail.so.0.0.0
> $ abidw $lib >bar; abidiff --harmless bar $lib | less
> abidiff: abg-reader.cc:1359: abigail::ir::type_base_sptr
> abigail::xml_reader::read_context::build_or_get_type_decl(const string&,
> bool): Assertion `__abg_cond__' failed.

I agree that this needs to be standard unit test.

The problem though, is that it takes a long time (5+ minutes) on the old
Rawhide box that I use for hacking here.  I guess I'll need to do some
performance work on this front at some point again.

Until, then, I don't feel like making this test be part of the standard "ma=
ke
check" of the project.

However, I have added a new "make check-self-compare" target to the project
which does exactly that.  I'll run this from time to time and I'll run it f=
or
sure before each release.  If someone has a powerful build box somewhere to=
 run
this, that would be great as well.

The current content of the master branch should now be able to correctly run
this.

Thanks for pointing this out!

--=20
You are receiving this mail because:
You are on the CC list for the bug.=