From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 6DF31393BC2A; Fri, 20 Nov 2020 15:29:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DF31393BC2A From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/26769] abixml writer misses some member types in the output Date: Fri, 20 Nov 2020 15:29:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2020 15:29:12 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26769 --- Comment #10 from dodji at redhat dot com --- (In reply to Ben Woodard from comment #8) > Rather than approaching this the way that you are, may I suggest doing wh= at > I'm doing which I believe is much simpler. >=20 > I run debuginfod and have a local repository of all the debuginfo RPMs. T= he > current elfutils provides this and it works extremely well. Yes, that is true that debuginfod works well. However, I went ahead and added a new --self-check option to abipkgdiff. That way you can get the RPM packages of the program you want to use to validate libabigail on and type: $ time abipkgdiff --self-check --d1 gcc-debuginfo-10.2.1-8.fc34.x86_64.rpm = --d1 libstdc++-debuginfo-10.2.1-8.fc34.x86_64.rpm libstdc++-10.2.1-8.fc34.x86_64= .rpm=20 =3D=3D=3D=3D SELF CHECK SUCCEEDED for 'libstdc++.so.6.0.28' =3D=3D=3D=3D real 0m33,288s user 0m30,189s sys 0m5,312s $=20 What it does is that it compares the binaries inside the RPM against their ABIXML representation, using the debug info provided by the ancillary debug= info packages. One advantage of doing that is that I could make the "fedabipkgdiff" too to= use that new option as well. Now we can ask "fedabipkgidff" to do the same on = any fedora package and that tool handles the downloading of all ancillary packa= ges for us, and it performs the test for *all* architectures (not just the curr= ent one you are running your box on). All that with just one command. For instance, here is how I can ask "fedabipkgdiff" to perform that check on all the sub-packags of the "boost" package from fedora 34: $ fedabipkgdiff -a --debug --abipkgdiff build/tools/abipkgdiff --from fc34 --self-compare boost Note that the --abipkgdiff option is to tell the tool to use a non-installed version of the abipkgdiff program that I have just built from source revisi= on control. Hopefully, this has some value for us to improve our coarse grain regression tests like the one at https://pagure.io/libabigail-selfcheck/tree/master I have now updated abipkgdiff and fedabipkgdiff in the branch https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dshortlog;h=3Drefs/heads/= dodji/PR26769 --=20 You are receiving this mail because: You are on the CC list for the bug.=