From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 726D33851C3B; Sat, 28 Nov 2020 11:11:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 726D33851C3B From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/26943] inexplicable type changing when running abidiff Date: Sat, 28 Nov 2020 11:11:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Nov 2020 11:11:29 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26943 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from dodji at redhat dot com --- Just some context on this issue. There are actually two issues here. One is the root issue and the second i= s a corollary. The first issue is that libabigail has subtle bugs that make it either misrepresent some characteristics of some ABI artifact when it loads them f= rom DWARF or forget to serialize some of those characteristics into ABIXML. So later when the internal representation (IR) coming from the DWARF is compared to the IR coming from the ABIXML, spurious ABI changes are reporte= d, due to this first issue. In general those misrepresented characteristics don't induce ABI changes th= at are considered incompatible. Those changes are usually harmless. The second issue is that abidw --abidiff emits an error only if comparing t= he IR coming from the binary against the IR coming from its ABIXML yields *incompatible* ABI changes. It won't emit an error for harmless changes. The second issue is actually by design. I did that because until now, I di= dn't fix all those little (but real) bugs that constitute the first issue. So, = for abidw --abidff to still be useful I made the choice of having it ignore harmless changes. It helped us catch several "bigger" problems like crashes and actual incompatible ABI changes that were occurring while comparing the binary against its ABIXML representation.=20 So I sat down to chase those bugs to fix the first issue. That led me to changing abidw --abidiff to make it complain for harmless issues as well. This led to patches the patch set https://sourceware.org/pipermail/libabigail/2020q4/002920.html that was app= ly to master recently. With that patch set in master, this problem is now fixed. Meaning the two issues described above should now be solved. Note that 'abipkgdiff --self-check' has also been updated to complain even for harmless changes. Thanks for reporting this problem! --=20 You are receiving this mail because: You are on the CC list for the bug.=